[libvirt] [PATCH] qemud: move check for polkit before config file check
Hi, Without this patch and without a /etc/libvirt/libvirt.conf config file the default policy for running the daemon as non root user is still polkit which is bad. Please apply. Cheers, -- Guido
On Sat, Jul 26, 2008 at 07:02:59PM -0400, Guido G?nther wrote:
Hi, Without this patch and without a /etc/libvirt/libvirt.conf config file the default policy for running the daemon as non root user is still polkit which is bad. Please apply.
Urgh, yes there's a hidden 'return' statement on the same line as the conditional access check further up causing this to be skipped when no config is present. ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Tue, Jul 29, 2008 at 11:11:16AM +0100, Daniel P. Berrange wrote:
On Sat, Jul 26, 2008 at 07:02:59PM -0400, Guido G?nther wrote:
Hi, Without this patch and without a /etc/libvirt/libvirt.conf config file the default policy for running the daemon as non root user is still polkit which is bad. Please apply.
Urgh, yes there's a hidden 'return' statement on the same line as the conditional access check further up causing this to be skipped when no config is present.
okidoc, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Guido Günther