[libvirt] [PATCH] Fix the initialization of the number of sockets
When starting a VM 3 times, on the 3rd time the number of sockets is completely out of control. Initialize the socket numbers to zero so the cpu affinity does not occur due to max cpus being completely out of range and the VM can start. Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
On 03/09/2010 10:34 AM, Stefan Berger wrote:
When starting a VM 3 times, on the 3rd time the number of sockets is completely out of control. Initialize the socket numbers to zero so the cpu affinity does not occur due to max cpus being completely out of range and the VM can start.
ACK. However, are there any of the other fields that also need initialization to known values? I see nothing setting nodeinfo->model, nodeinfo->memory, nodeinfo->threads. In particular, it looks like nodeinfo->threads is read uninitialized in the same function. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 03/09/2010 01:14 PM, Eric Blake wrote:
On 03/09/2010 10:34 AM, Stefan Berger wrote:
When starting a VM 3 times, on the 3rd time the number of sockets is completely out of control. Initialize the socket numbers to zero so the cpu affinity does not occur due to max cpus being completely out of range and the VM can start.
ACK. However, are there any of the other fields that also need initialization to known values? I see nothing setting nodeinfo->model, nodeinfo->memory, nodeinfo->threads. In particular, it looks like nodeinfo->threads is read uninitialized in the same function.
Jirka fixed both of these earlier today with 22e39d0ee445173610bab6fbead676abd528627b. -- Chris Lalancette
participants (3)
-
Chris Lalancette -
Eric Blake -
Stefan Berger