[libvirt] Libvirt 0.9.1 week freeze, RC1 version to test
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.1-rc1.tar.gz I have tried it locally and basic operations seems to work fine, please give it a try too, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
2011/4/28 Daniel Veillard <veillard@redhat.com>:
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.1-rc1.tar.gz
I have tried it locally and basic operations seems to work fine, please give it a try too,
thanks !
Daniel
Testing on mingw. libvirt compiles fine but virsh has a warning about vfprintf: virsh.c: In function 'vshDebug': virsh.c:12105:5: warning: function might be possible candidate for 'ms_printf' format attribute [-Wmissing-format-attribute] I'm no sure where to fix that. make check shows two warnings in gnulib. Maybe Eric wants to take a look: getsockopt.c: In function 'rpl_getsockopt': getsockopt.c:51:7: warning: passing argument 4 of 'getsockopt' from incompatible pointer type c:\dev\msys_setup\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:543:32: note: expected 'char *' but argument is of type 'int *' test-getaddrinfo.c:28:1: warning: initialization from incompatible pointer type Aside from that the rest seems to work fine. Matthias
On 04/28/2011 01:33 AM, Matthias Bolte wrote:
libvirt compiles fine but virsh has a warning about vfprintf:
virsh.c: In function 'vshDebug': virsh.c:12105:5: warning: function might be possible candidate for 'ms_printf' format attribute [-Wmissing-format-attribute]
I'm no sure where to fix that.
In mingw's <stdio.h>. But we can't do that. vfprintf is NOT being provided by gnulib, so it does NOT understand %zu or %llu. Yet we use it with %zu. So the only real solution is to use virAsprintf (which _does_ understand %zu, thanks to gnulib) and make vshDebug go through an intermediate buffer, then use fputs on that string, rather than relying directly on the unsanitized vfprintf. Patch coming up shortly.
make check shows two warnings in gnulib. Maybe Eric wants to take a look:
getsockopt.c: In function 'rpl_getsockopt': getsockopt.c:51:7: warning: passing argument 4 of 'getsockopt' from incompatible pointer type c:\dev\msys_setup\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:543:32: note: expected 'char *' but argument is of type 'int *'
Yep, I can fix that one in gnulib; I'll have a counterpart patch to bump .gnulib to the latest once I've got it done.
test-getaddrinfo.c:28:1: warning: initialization from incompatible pointer type
Probably the same category of gnulib fix.
Aside from that the rest seems to work fine.
So I fixed the non-blocking pipe issues that broke 0.9.0 virsh out-of-the-box? Good to hear. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
2011/4/28 Eric Blake <eblake@redhat.com>:
On 04/28/2011 01:33 AM, Matthias Bolte wrote:
libvirt compiles fine but virsh has a warning about vfprintf:
virsh.c: In function 'vshDebug': virsh.c:12105:5: warning: function might be possible candidate for 'ms_printf' format attribute [-Wmissing-format-attribute]
I'm no sure where to fix that.
In mingw's <stdio.h>. But we can't do that.
vfprintf is NOT being provided by gnulib, so it does NOT understand %zu or %llu. Yet we use it with %zu.
So the only real solution is to use virAsprintf (which _does_ understand %zu, thanks to gnulib) and make vshDebug go through an intermediate buffer, then use fputs on that string, rather than relying directly on the unsanitized vfprintf. Patch coming up shortly.
Yep, fixed now.
make check shows two warnings in gnulib. Maybe Eric wants to take a look:
getsockopt.c: In function 'rpl_getsockopt': getsockopt.c:51:7: warning: passing argument 4 of 'getsockopt' from incompatible pointer type c:\dev\msys_setup\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:543:32: note: expected 'char *' but argument is of type 'int *'
Yep, I can fix that one in gnulib; I'll have a counterpart patch to bump .gnulib to the latest once I've got it done.
test-getaddrinfo.c:28:1: warning: initialization from incompatible pointer type
Probably the same category of gnulib fix.
Also fixed now.
Aside from that the rest seems to work fine.
So I fixed the non-blocking pipe issues that broke 0.9.0 virsh out-of-the-box? Good to hear.
At least the call to virEventRegisterDefaultImpl in virsh doesn't fail anymore, so the pipe setup and stuff seems to work, or at least does not fail anymore. :) Current git + pending (but already ACK'ed) patches from Eric compiles and works fine on mingw, as far as I can tell. Matthias
于 2011年04月28日 11:51, Daniel Veillard 写道:
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.1-rc1.tar.gz
I have tried it locally and basic operations seems to work fine, please give it a try too,
thanks !
Daniel
Works fine on my FC14, except once one defines a lxc domain, there is errors always in libvirtd log. 15:42:29.547: 3632: error : lxcMonitorClient:1151 : Failed to connect to client socket: No such file or directory 15:42:29.547: 3632: error : lxcMonitorClient:1151 : Failed to connect to client socket: No such file or directory Caused by lxcStartup tries to reconnect to the lxc domains, regardsless of if the domain is active or not. I'm fixing it. Osier
I have made a release candidate 2 version, ftp://libvirt.org/libvirt/libvirt-0.9.1-rc2.tar.gz Assuming everything goes fine I will try to push the release on Wed, if there is a problem, an rc3 and an end of week release is also possible, but hopefully that looks fine overall ! Thanks everybody for the bug chase, and running valgrind ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
2011/5/2 Daniel Veillard <veillard@redhat.com>:
I have made a release candidate 2 version,
ftp://libvirt.org/libvirt/libvirt-0.9.1-rc2.tar.gz
Assuming everything goes fine I will try to push the release on Wed, if there is a problem, an rc3 and an end of week release is also possible, but hopefully that looks fine overall !
Thanks everybody for the bug chase, and running valgrind !
Daniel
Tested on mingw compiles and works find as far as I can tell. But make check fails in one of the gnulib tests, I'm not sure if this is a problem that requires a rc3 or not. Maybe Eric wants to take a look at this one too: test-nonblocking-reader.h:112: assertion failed This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information. (null): ./test-nonblocking-socket-child.exe subprocess got fatal signal 15 test-nonblocking-socket-main.c:119: assertion failed This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information. FAIL: test-nonblocking-socket.sh Matthias
On 05/02/2011 07:13 AM, Matthias Bolte wrote:
Tested on mingw compiles and works find as far as I can tell.
But make check fails in one of the gnulib tests, I'm not sure if this is a problem that requires a rc3 or not. Maybe Eric wants to take a look at this one too:
test-nonblocking-reader.h:112: assertion failed
Probably a known issue in gnulib. Sockets on mingw are a weird beast, and upstream gnulib is still trying to make it work nicer (Bruno Haible has been most active on that front recently), although I won't hold my breath for any fixes in time for libvirt 0.9.1. Which means we'll just have to ignore that gnulib unit test failure for now. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (4)
-
Daniel Veillard -
Eric Blake -
Matthias Bolte -
Osier Yang