Re: [libvirt] [PATCH] qemu: live change of the bridge used by a guest network device
Is this patch too much "new code" to push now? https://www.redhat.com/archives/libvir-list/2012-March/msg01228.html The reasons I ask are two-fold - 1) it sat for a long time before anybody reviewed it. 2) I just noticed that there is a bug in the existing code that fails to flag a change in bridge name as an error (although it does nothing with it), and this patch would remedy that, so in one way it could be considered a bugfix.
On 03/28/2012 12:57 PM, Laine Stump wrote:
Is this patch too much "new code" to push now?
https://www.redhat.com/archives/libvir-list/2012-March/msg01228.html
The reasons I ask are two-fold -
1) it sat for a long time before anybody reviewed it.
2) I just noticed that there is a bug in the existing code that fails to flag a change in bridge name as an error (although it does nothing with it), and this patch would remedy that, so in one way it could be considered a bugfix.
I'm okay calling it a bugfix and pushing it now; the code has been available pre-freeze, and appears to be relatively isolated in what it touches. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Laine Stump