[libvirt] [PATCH] Have a colorful nodedev.rng with vi
Just add the head line to let vi known it's a XML document. --- docs/schemas/nodedev.rng | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 7c85815..04d8ee9 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -1,3 +1,4 @@ +<?xml version="1.0"?> <!-- A Relax NG schema for the libvirt node device XML format --> <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> -- 1.7.7.6
On 2013年01月18日 17:19, Osier Yang wrote:
Just add the head line to let vi known it's a XML document.
s/with vi//, s/let vi/let editor/,
--- docs/schemas/nodedev.rng | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 7c85815..04d8ee9 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -1,3 +1,4 @@ +<?xml version="1.0"?> <!-- A Relax NG schema for the libvirt node device XML format --> <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
On 01/18/2013 02:19 AM, Osier Yang wrote:
Just add the head line to let vi known it's a XML document.
s/known/know/
--- docs/schemas/nodedev.rng | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
ACK to the idea, but before you push...
diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 7c85815..04d8ee9 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -1,3 +1,4 @@ +<?xml version="1.0"?>
Please extend this to cover ALL of the .rng files; right now, my quick grep showed two other culprits that need the same fix (vs. 11 that were correct): $ grep -l -L '?xml version=.1' docs/schemas/*.rng docs/schemas/capability.rng docs/schemas/nodedev.rng docs/schemas/storageencryption.rng -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 2013年01月19日 00:56, Eric Blake wrote:
On 01/18/2013 02:19 AM, Osier Yang wrote:
Just add the head line to let vi known it's a XML document.
s/known/know/
--- docs/schemas/nodedev.rng | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
ACK to the idea, but before you push...
diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 7c85815..04d8ee9 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -1,3 +1,4 @@ +<?xml version="1.0"?>
Please extend this to cover ALL of the .rng files; right now, my quick grep showed two other culprits that need the same fix (vs. 11 that were correct):
$ grep -l -L '?xml version=.1' docs/schemas/*.rng docs/schemas/capability.rng docs/schemas/nodedev.rng docs/schemas/storageencryption.rng
Yeah, the grep result is correct. I extended the patch and pushed. Thanks. Osier
participants (2)
-
Eric Blake -
Osier Yang