Re: [libvirt] [PATCH] snip my name and email
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c. NB, your name & email are still recorded in git history and email archives for eternity Your name, but not email, is also mentioned in the news files, and that file isn't one we'd want to remove since its relevant historical record.
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index e1ec8e7..a3f8af1 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani <davidkiarie4@gmail.com> * Author: Jim Fehlig <jfehlig@suse.com> */
diff --git a/src/xenconfig/xen_xl.h b/src/xenconfig/xen_xl.h index dd96326..8342f53 100644 --- a/src/xenconfig/xen_xl.h +++ b/src/xenconfig/xen_xl.h @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani<davidkiarie4@gmail.com> */
#ifndef __VIR_XEN_XL_H__ -- 2.16.2
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
NB, your name & email are still recorded in git history and email archives for eternity
Your name, but not email, is also mentioned in the news files, and that file isn't one we'd want to remove since its relevant historical record.
I prefectly understand that.
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index e1ec8e7..a3f8af1 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani <davidkiarie4@gmail.com> * Author: Jim Fehlig <jfehlig@suse.com> */
diff --git a/src/xenconfig/xen_xl.h b/src/xenconfig/xen_xl.h index dd96326..8342f53 100644 --- a/src/xenconfig/xen_xl.h +++ b/src/xenconfig/xen_xl.h @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani<davidkiarie4@gmail.com> */
#ifndef __VIR_XEN_XL_H__ -- 2.16.2
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/ dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/ dberrange :|
On Wed, Mar 28, 2018 at 7:33 PM, David Kiarie <davidkiarie4@gmail.com> wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
NB, your name & email are still recorded in git history and email archives for eternity
Your name, but not email, is also mentioned in the news files, and that file isn't one we'd want to remove since its relevant historical record.
I prefectly understand that.
*perfectly, that is ;-)
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index e1ec8e7..a3f8af1 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani <davidkiarie4@gmail.com> * Author: Jim Fehlig <jfehlig@suse.com> */
diff --git a/src/xenconfig/xen_xl.h b/src/xenconfig/xen_xl.h index dd96326..8342f53 100644 --- a/src/xenconfig/xen_xl.h +++ b/src/xenconfig/xen_xl.h @@ -17,7 +17,6 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Author: Kiarie Kahurani<davidkiarie4@gmail.com> */
#ifndef __VIR_XEN_XL_H__ -- 2.16.2
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/ dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dber range :|
On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
NB, patches require a Signed-off-by line to be commited, so can you resend with that.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
And presumably you want to remove from this file too ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé <berrange@redhat.com
wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
NB, patches require a Signed-off-by line to be commited, so can you resend with that.
I'm just angry about some internet idiot who might use my name to track me around.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
And presumably you want to remove from this file too ?
I'm just confused. Not so sure he's smart enough to figure that out.
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/ dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/ dberrange :|
On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie <davidkiarie4@gmail.com> wrote:
On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé < berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
NB, patches require a Signed-off-by line to be commited, so can you resend with that.
I'm just angry about some internet idiot who might use my name to track me around.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
And presumably you want to remove from this file too ?
I'm just confused. Not so sure he's smart enough to figure that out.
Okay, shall I redo this patch or would you be kind enough to do it ?
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/ dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dber range :|
On Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie <davidkiarie4@gmail.com> wrote:
On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé < berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
NB, patches require a Signed-off-by line to be commited, so can you resend with that.
I'm just angry about some internet idiot who might use my name to track me around.
--- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
And presumably you want to remove from this file too ?
I'm just confused. Not so sure he's smart enough to figure that out.
Okay, shall I redo this patch or would you be kind enough to do it ?
You'll need to resend, and also add a Signed-off-by line so that we can commit it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Mar 28, 2018 at 7:52 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie <davidkiarie4@gmail.com> wrote:
On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé <
berrange@redhat.com>
wrote:
On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé < berrange@redhat.com> wrote:
On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote: > I'd like to snip my name and email from these files
Any particular reason why ?
Yes, I do have a particular reason why but it's not very relevant around here.
NB, patches require a Signed-off-by line to be commited, so can you resend with that.
I'm just angry about some internet idiot who might use my name to
On Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote: track me
around.
> --- > src/xenconfig/xen_xl.c | 1 - > src/xenconfig/xen_xl.h | 1 - > 2 files changed, 2 deletions(-)
It is also mentioned in test/xlconfigtest.c.
And presumably you want to remove from this file too ?
I'm just confused. Not so sure he's smart enough to figure that out.
Okay, shall I redo this patch or would you be kind enough to do it ?
You'll need to resend, and also add a Signed-off-by line so that we can commit it.
What ? You mean my patch didn't have a Signed-off-by line ?! It's long since I did git.
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/ dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/ dberrange :|
participants (2)
-
Daniel P. Berrangé -
David Kiarie