[libvirt] [PATCH] Fix common misspellings
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives. [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_mac... Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want. docs/bugs.html.in | 2 +- docs/contact.html.in | 2 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/interface.rng | 2 +- docs/securityprocess.html.in | 6 +++--- examples/systemtap/lock-debug.stp | 2 +- include/libvirt/libvirt-host.h | 2 +- include/libvirt/virterror.h | 2 +- src/bhyve/bhyve_driver.c | 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/datatypes.c | 4 ++-- src/network/bridge_driver_linux.c | 2 +- src/qemu/THREADS.txt | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virfirewall.c | 2 +- src/util/virprocess.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_common.h | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_xm.c | 2 +- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 22 files changed, 27 insertions(+), 27 deletions(-) diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 140d1b4..55ceb60 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@ <p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security diff --git a/docs/contact.html.in b/docs/contact.html.in index 51cc775..9ab0ab9 100644 --- a/docs/contact.html.in +++ b/docs/contact.html.in @@ -10,7 +10,7 @@ <p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 3e1841c..8b49a27 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@ <!--interface on a device (system). The duid is often used by servers --> <!--such as dnsmasq to assign a specific IP address (and optionally a --> <!--name to an interface. The applicable standards are RFC3315 and --> - <!--RFC6355. These standards actualy require the duid to be fixed for --> + <!--RFC6355. These standards actually require the duid to be fixed for --> <!--the hardward device and applicable to all network interfaces on --> <!--that device. It is not clear that any software currently enforces --> <!--this requirement although it could be implemented manually. --> diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index d78f877..bf0346c 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> <!-- Versions for this schema are simple integers that are incremented - everytime a changed (but backwards compatible) version + every time a changed (but backwards compatible) version is released. The current version is indicated with the v:serial attribute on the start element. --> diff --git a/docs/securityprocess.html.in b/docs/securityprocess.html.in index 3efd687..bdef1e9 100644 --- a/docs/securityprocess.html.in +++ b/docs/securityprocess.html.in @@ -66,9 +66,9 @@ <p> The libvirt security team operates a policy of <a href="http://en.wikipedia.org/wiki/Responsible_disclosure">responsible disclosure</a>. - As such any security issue reported, that is not already publically disclosed + As such any security issue reported, that is not already publicly disclosed elsewhere, will have an embargo date assigned. Members of the security team agree - not to publically disclose any details of the security issue until the embargo + not to publicly disclose any details of the security issue until the embargo date expires. </p> @@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be negotiated by mutual agreement between members of the security team and other relevant parties to the problem. Any such extended embargoes will aim to be at most one month in duration. diff --git a/examples/systemtap/lock-debug.stp b/examples/systemtap/lock-debug.stp index 8f06340..78e94ba 100644 --- a/examples/systemtap/lock-debug.stp +++ b/examples/systemtap/lock-debug.stp @@ -49,7 +49,7 @@ probe unlock = library.function("virMutexUnlock") probe begin { %( $# > 1 %? println("error: Too many parameters"); exit(); - %: print("Started, press ^C when the proccess hangs\n"); %) + %: print("Started, press ^C when the process hangs\n"); %) } probe lock.call diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 77058af..953366b 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -218,7 +218,7 @@ typedef enum { * * The types virSchedParameter, virBlkioParameter, and * virMemoryParameter are aliases of this type, for use when - * targetting libvirt earlier than 0.9.2. + * targeting libvirt earlier than 0.9.2. */ typedef struct _virTypedParameter virTypedParameter; diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 3d3d80a..5dc99dc 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -304,7 +304,7 @@ typedef enum { VIR_ERR_STORAGE_VOL_EXIST = 90, /* the storage vol already exists */ VIR_ERR_CPU_INCOMPATIBLE = 91, /* given CPU is incompatible with host CPU*/ - VIR_ERR_XML_INVALID_SCHEMA = 92, /* XML document doens't validate against schema */ + VIR_ERR_XML_INVALID_SCHEMA = 92, /* XML document doesn't validate against schema */ } virErrorNumber; /** diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 33a12be..21db277 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1160,14 +1160,14 @@ bhyveStateCleanup(void) } static int -bhyveStateInitialize(bool priveleged, +bhyveStateInitialize(bool privileged, virStateInhibitCallback callback ATTRIBUTE_UNUSED, void *opaque ATTRIBUTE_UNUSED) { virConnectPtr conn = NULL; - if (!priveleged) { - VIR_INFO("Not running priveleged, disabling driver"); + if (!privileged) { + VIR_INFO("Not running privileged, disabling driver"); return 0; } diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c index c77374c..733a0cd 100644 --- a/src/cpu/cpu_powerpc.c +++ b/src/cpu/cpu_powerpc.c @@ -102,7 +102,7 @@ ppcModelFindPVR(const struct ppc_map *map, /* PowerPC Processor Version Register is interpreted as follows : * Higher order 16 bits : Power ISA generation. * Lower order 16 bits : CPU chip version number. - * If the exact CPU isnt found, return the nearest matching CPU generation + * If the exact CPU isn't found, return the nearest matching CPU generation */ if (pvr & 0x0000FFFFul) return ppcModelFindPVR(map, (pvr & 0xFFFF0000ul)); diff --git a/src/datatypes.c b/src/datatypes.c index 1afaf00..0f535b4 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -377,7 +377,7 @@ virInterfaceDispose(void *obj) * @name: pointer to the storage pool name * @uuid: pointer to the uuid * @privateData: pointer to driver specific private data - * @freeFunc: private data cleanup function pointer specfic to driver + * @freeFunc: private data cleanup function pointer specific to driver * * Allocates a new storage pool object. When the object is no longer needed, * virObjectUnref() must be called in order to not leak data. @@ -453,7 +453,7 @@ virStoragePoolDispose(void *obj) * @name: pointer to the storage vol name * @key: pointer to unique key of the volume * @privateData: pointer to driver specific private data - * @freeFunc: private data cleanup function pointer specfic to driver + * @freeFunc: private data cleanup function pointer specific to driver * * Allocates a new storage volume object. When the object is no longer needed, * virObjectUnref() must be called in order to not leak data. diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index aa2ad10..e394daf 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -450,7 +450,7 @@ networkRemoveGeneralIPv4FirewallRules(virFirewallPtr fw, /* Add all once/network rules required for IPv6. * If no IPv6 addresses are defined and <network ipv6='yes'> is - * specified, then allow IPv6 commuinications between virtual systems. + * specified, then allow IPv6 communications between virtual systems. * If any IPv6 addresses are defined, then add the rules for regular operation. */ static void diff --git a/src/qemu/THREADS.txt b/src/qemu/THREADS.txt index dfa372b..1ad63cc 100644 --- a/src/qemu/THREADS.txt +++ b/src/qemu/THREADS.txt @@ -29,7 +29,7 @@ There are a number of locks on various objects methods. However, preferred method is qemuDomObjFromDomain() that uses virDomainFindByUUIDRef() which also increases the reference counter and finds the domain in the domain list without blocking all other lookups. - When the domain is locked and the reference increased, the prefered way of + When the domain is locked and the reference increased, the preferred way of decrementing the reference counter and unlocking the domain is using the qemuDomObjEndAPI() function. diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ccf22f0..ce6767c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1266,7 +1266,7 @@ virQEMUCapsComputeCmdFlags(const char *help, * promises to keep the human interface stable, but requests that * we use QMP (the JSON interface) for everything. If the user * forgot to include YAJL libraries when building their own - * libvirt but is targetting a newer qemu, we are better off + * libvirt but is targeting a newer qemu, we are better off * telling them to recompile (the spec file includes the * dependency, so distros won't hit this). This check is * also in m4/virt-yajl.m4 (see $with_yajl). */ diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6d9217b..3cd5f8b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6357,7 +6357,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver, * @open_write: open the file for writing (for updates) * @unlink_corrupt: remove the image file if it is corrupted * - * Returns the opened fd of the save image file and fills the apropriate fields + * Returns the opened fd of the save image file and fills the appropriate fields * on success. On error returns -1 on most failures, -3 if corrupt image was * unlinked (no error raised). */ diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index cd7afa5..2251f97 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -945,7 +945,7 @@ virFirewallApply(virFirewallPtr firewall) VIR_DEBUG("Applying groups for %p", firewall); for (i = 0; i < firewall->ngroups; i++) { if (virFirewallApplyGroup(firewall, i) < 0) { - VIR_DEBUG("Rolling back groups upto %zu for %p", i, firewall); + VIR_DEBUG("Rolling back groups up to %zu for %p", i, firewall); size_t first = i; virErrorPtr saved_error = virSaveLastError(); diff --git a/src/util/virprocess.c b/src/util/virprocess.c index aa00a99..ab1e039 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -354,7 +354,7 @@ virProcessKillPainfully(pid_t pid, bool force) /* This loop sends SIGTERM, then waits a few iterations (10 seconds) * to see if it dies. If the process still hasn't exited, and * @force is requested, a SIGKILL will be sent, and this will - * wait upto 5 seconds more for the process to exit before + * wait up to 5 seconds more for the process to exit before * returning. * * Note that setting @force could result in dataloss for the process. diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 0fb53aa..20211b2 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -7413,7 +7413,7 @@ vboxConnectListAllDomains(virConnectPtr conn, /* filter out flag options that will produce 0 results in vbox driver: * - managed save: vbox guests don't have managed save images * - autostart: vbox doesn't support autostarting guests - * - persistance: vbox doesn't support transient guests + * - persistence: vbox doesn't support transient guests */ if ((MATCH(VIR_CONNECT_LIST_DOMAINS_TRANSIENT) && !MATCH(VIR_CONNECT_LIST_DOMAINS_PERSISTENT)) || diff --git a/src/vbox/vbox_common.h b/src/vbox/vbox_common.h index d318921..f9ce612 100644 --- a/src/vbox/vbox_common.h +++ b/src/vbox/vbox_common.h @@ -32,7 +32,7 @@ * vbox_CAPI_v*.h. It tells the vbox_common.c * how to treat with this symbols. This file * can't be included with files such as - * vbox_CAPI_v*.h, or it would casue multiple + * vbox_CAPI_v*.h, or it would cause multiple * definitions. * * You can see the more informations in vbox_api.h diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 6c8ec7c..3813900 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -523,7 +523,7 @@ xend_op_ext(virConnectPtr xend, const char *path, const char *key, va_list ap) * @ap: input values to pass to the operation * @...: input values to pass to the operation * - * internal routine to run a POST RPC operation to the Xen Daemon targetting + * internal routine to run a POST RPC operation to the Xen Daemon targeting * a given domain. * * Returns 0 in case of success, -1 in case of failure. diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 5d70af6..c6bdbd3 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -469,7 +469,7 @@ xenFormatXMInputDevs(virConfPtr conf, virDomainDefPtr def) verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT); /* - * Convert a virDomainDef object inot an XM config record. + * Convert a virDomainDef object into an XM config record. */ virConfPtr xenFormatXM(virConnectPtr conn, diff --git a/tools/wireshark/samples/libvirt-sample.pdml b/tools/wireshark/samples/libvirt-sample.pdml index f6a4c28..abe7fbb 100644 --- a/tools/wireshark/samples/libvirt-sample.pdml +++ b/tools/wireshark/samples/libvirt-sample.pdml @@ -3,7 +3,7 @@ <!-- *** This file has been reduced for ineffective packets. Real output contains more and more elements, but structure - and hierarchy of XML is same as this exmaple. + and hierarchy of XML is same as this example. *** --> <!-- You can find pdml2html.xsl in /usr/share/wireshark or at http://anonsvn.wireshark.org/trunk/wireshark/pdml2html.xsl. --> <pdml version="0" creator="wireshark/1.10.2" time="Thu Sep 19 18:09:24 2013" capture_file=""> -- 2.3.3
On Fri, Mar 20, 2015 at 01:21:06PM +0100, Martin Kletzander wrote:
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left
Thankfully, none of the three spellings are present in the git.
untouched. The list of changes was manually re-checked for false positives.
[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_mac...
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want.
docs/bugs.html.in | 2 +- docs/contact.html.in | 2 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/interface.rng | 2 +- docs/securityprocess.html.in | 6 +++--- examples/systemtap/lock-debug.stp | 2 +- include/libvirt/libvirt-host.h | 2 +- include/libvirt/virterror.h | 2 +- src/bhyve/bhyve_driver.c | 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/datatypes.c | 4 ++-- src/network/bridge_driver_linux.c | 2 +- src/qemu/THREADS.txt | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virfirewall.c | 2 +- src/util/virprocess.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_common.h | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_xm.c | 2 +- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 22 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 140d1b4..55ceb60 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@
<p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security
I'm not convinced 'publically' is wrong, but 'publicly' is much more common. ACK Jan
On Fri, Mar 20, 2015 at 01:47:01PM +0100, Ján Tomko wrote:
On Fri, Mar 20, 2015 at 01:21:06PM +0100, Martin Kletzander wrote:
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left
Thankfully, none of the three spellings are present in the git.
That was just a example (see that "e.g."), there are 206 of those. You made me to go through those as well, all except one were false positives (e.g. '"$@" -Wc,+Maked'), so I squashed this in: diff --git i/src/util/virhostdev.c w/src/util/virhostdev.c index 9678e2b..23365a3 100644 --- i/src/util/virhostdev.c +++ w/src/util/virhostdev.c @@ -569,7 +569,7 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr, /* The device is in use by other active domain if * the dev is in list activePCIHostdevs. VFIO devices - * belonging to same iommu group cant be shared + * belonging to same iommu group can't be shared * across guests. */ if (STREQ(virPCIDeviceGetStubDriver(dev), "vfio-pci")) { --
untouched. The list of changes was manually re-checked for false positives.
[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_mac...
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want.
docs/bugs.html.in | 2 +- docs/contact.html.in | 2 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/interface.rng | 2 +- docs/securityprocess.html.in | 6 +++--- examples/systemtap/lock-debug.stp | 2 +- include/libvirt/libvirt-host.h | 2 +- include/libvirt/virterror.h | 2 +- src/bhyve/bhyve_driver.c | 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/datatypes.c | 4 ++-- src/network/bridge_driver_linux.c | 2 +- src/qemu/THREADS.txt | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virfirewall.c | 2 +- src/util/virprocess.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_common.h | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_xm.c | 2 +- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 22 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 140d1b4..55ceb60 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@
<p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security
I'm not convinced 'publically' is wrong, but 'publicly' is much more common.
"publically" looks/sounds very weird to me, but I can't say for sure whether it's "just plain wrong" or if the rules are just old. But there were worse ones than that. I've left out "ok" (which should be OK, but it looks like nobody cares and there were *so many* false positives in the code), and there's "(in)dependant" where it suggests s/dant/dent/ and I couldn't find anywhere that the version with 'a' is wrong, but I see a lot of consistent usage of that and even my spell-checker doesn't mark it as wrong. I'll leave out the public+ally if someone strongly disagrees.
ACK
Thanks for the review. I was thinking some more native speaker will have a look as well, so I'll wait for a while if there are any oppositions to this.
Jan
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 03/20/2015 07:40 AM, Martin Kletzander wrote:
That was just a example (see that "e.g."), there are 206 of those. You made me to go through those as well, all except one were false positives (e.g. '"$@" -Wc,+Maked'), so I squashed this in:
diff --git i/src/util/virhostdev.c w/src/util/virhostdev.c index 9678e2b..23365a3 100644 --- i/src/util/virhostdev.c +++ w/src/util/virhostdev.c @@ -569,7 +569,7 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr,
/* The device is in use by other active domain if * the dev is in list activePCIHostdevs. VFIO devices - * belonging to same iommu group cant be shared + * belonging to same iommu group can't be shared * across guests.
ACK (Many times, typos are obvious when flagged by spell-checkers; other times, like here, the misspelling is still a valid word so it is easier to overlook when it doesn't have the UI squiggle underline to point out the potential typo. But I seldom hear 'cant' in a real sentence, and it's true that iommu groups don't intone chants :)
I'll leave out the public+ally if someone strongly disagrees.
No, keep your changes to 'publicly'. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Fri, Mar 20, 2015 at 02:40:05PM +0100, Martin Kletzander wrote:
I've left out "ok" (which should be OK, but it looks like nobody cares and there were *so many* false positives in the code), and there's "(in)dependant" where it suggests s/dant/dent/ and I couldn't find anywhere that the version with 'a' is wrong, but I see a lot of consistent usage of that and even my spell-checker doesn't mark it as wrong.
Dependant is the UK spelling of that person that financially depends on you, all other uses should use 'dent'. Jan
On Mon, Mar 23, 2015 at 09:58:40AM +0100, Ján Tomko wrote:
On Fri, Mar 20, 2015 at 02:40:05PM +0100, Martin Kletzander wrote:
I've left out "ok" (which should be OK, but it looks like nobody cares and there were *so many* false positives in the code), and there's "(in)dependant" where it suggests s/dant/dent/ and I couldn't find anywhere that the version with 'a' is wrong, but I see a lot of consistent usage of that and even my spell-checker doesn't mark it as wrong.
Dependant is the UK spelling of that person that financially depends on you, all other uses should use 'dent'.
Is that something that's just well known and I don't know that or do you have that from some particular place/page/person? I'd like to know more about some details. And to know whether I should send another version for some other words (when there's time, as this is not something we need). Just out of curiosity. Thanks Martin
On 03/20/2015 06:21 AM, Martin Kletzander wrote:
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives.
[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_mac...
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want.
Quite the list! As a native speaker...
+++ b/docs/bugs.html.in @@ -11,7 +11,7 @@
<p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly
Correct.
+++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@ <!--interface on a device (system). The duid is often used by servers --> <!--such as dnsmasq to assign a specific IP address (and optionally a --> <!--name to an interface. The applicable standards are RFC3315 and --> - <!--RFC6355. These standards actualy require the duid to be fixed for --> + <!--RFC6355. These standards actually require the duid to be fixed for --> <!--the hardward device and applicable to all network interfaces on -->
Alignment is now off.
+++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> <!-- Versions for this schema are simple integers that are incremented - everytime a changed (but backwards compatible) version + every time a changed (but backwards compatible) version is released. The current version is indicated with the v:serial attribute on the start element. -->
Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now.
@@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be
This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it. ACK to all these changes (modulo the alignment fix). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Fri, Mar 20, 2015 at 09:51:23AM -0600, Eric Blake wrote:
On 03/20/2015 06:21 AM, Martin Kletzander wrote:
Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives.
[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_mac...
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want.
Quite the list! As a native speaker...
+++ b/docs/bugs.html.in @@ -11,7 +11,7 @@
<p> If you think that an issue with libvirt may have security - implications, <strong>please do not</strong> publically + implications, <strong>please do not</strong> publicly
Correct.
+++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@ <!--interface on a device (system). The duid is often used by servers --> <!--such as dnsmasq to assign a specific IP address (and optionally a --> <!--name to an interface. The applicable standards are RFC3315 and --> - <!--RFC6355. These standards actualy require the duid to be fixed for --> + <!--RFC6355. These standards actually require the duid to be fixed for --> <!--the hardward device and applicable to all network interfaces on -->
Alignment is now off.
+++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> <!-- Versions for this schema are simple integers that are incremented - everytime a changed (but backwards compatible) version + every time a changed (but backwards compatible) version is released. The current version is indicated with the v:serial attribute on the start element. -->
Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now.
Well, this has something to do with netcf, I guess. Probably Laine (Cc'd) would be the one to answer that.
@@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be
This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it.
My en_GB.utf8 ispell only allows "embargoes". What is your opinion on "dependant" and similar words I've left out?
ACK to all these changes (modulo the alignment fix).
I pushed the patch with the alignment fixed and "publicly" kept, thanks for the reviews. Martin
On 03/23/2015 02:46 AM, Martin Kletzander wrote:
- In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be
This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it.
My en_GB.utf8 ispell only allows "embargoes". What is your opinion on "dependant" and similar words I've left out?
dependant is flagged as wrong in US dictionary (only valid in UK dictionary, and even then, it has only the financial sense and not the inter-relatedness sense that we are more prone to be wanting throughout code). There is no word 'independant' in either variant. So another patch to s/\(\(in\)\?depen\)dant/\1dent/ would be correct. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Mar 25, 2015 at 10:44:53AM -0600, Eric Blake wrote:
On 03/23/2015 02:46 AM, Martin Kletzander wrote:
- In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be
This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it.
My en_GB.utf8 ispell only allows "embargoes". What is your opinion on "dependant" and similar words I've left out?
dependant is flagged as wrong in US dictionary (only valid in UK dictionary, and even then, it has only the financial sense and not the inter-relatedness sense that we are more prone to be wanting throughout code). There is no word 'independant' in either variant. So another patch to s/\(\(in\)\?depen\)dant/\1dent/ would be correct.
Thanks for the explanation. I used it in the commit message for such patch. And s/dependan/dependen/ was enough, plus it revelaed 'dependancies' as well.
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 03/23/2015 04:46 AM, Martin Kletzander wrote:
On Fri, Mar 20, 2015 at 09:51:23AM -0600, Eric Blake wrote:
On 03/20/2015 06:21 AM, Martin Kletzander wrote: +++ b/docs/schemas/interface.rng
@@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> <!-- Versions for this schema are simple integers that are incremented - everytime a changed (but backwards compatible) version + every time a changed (but backwards compatible) version is released. The current version is indicated with the v:serial attribute on the start element. -->
Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now.
Well, this has something to do with netcf, I guess. Probably Laine (Cc'd) would be the one to answer that.
That schema is likely copied directly from netcf. I vaguely recall that the first time after initial public release that lutter added something to the schema (to support ipv6 I think), he updated the version, but wondered at the time just how necessary that was. Since that time it has never been updated, and I don't really see an upside to doing so.
participants (4)
-
Eric Blake -
Ján Tomko -
Laine Stump -
Martin Kletzander