3:55 a.m.
This ensures that the MANIFEST file is up-to-date, and thus dist will
(hopefully) work.
Signed-off-by: Pino Toscano <ptoscano(a)redhat.com>
---
guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
jenkins/projects/libvirt-ocaml.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml
b/guests/playbooks/build/projects/libvirt-ocaml.yml
index 7a2e216..d293738 100644
--- a/guests/playbooks/build/projects/libvirt-ocaml.yml
+++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
@@ -25,3 +25,4 @@
./configure --prefix=$VIRT_PREFIX
$MAKE
$MAKE opt
+ $MAKE check-manifest
diff --git a/jenkins/projects/libvirt-ocaml.yaml b/jenkins/projects/libvirt-ocaml.yaml
index 8eb03e3..158dee1 100644
--- a/jenkins/projects/libvirt-ocaml.yaml
+++ b/jenkins/projects/libvirt-ocaml.yaml
@@ -21,3 +21,4 @@
./configure --prefix=$VIRT_PREFIX
$MAKE
$MAKE opt
+ $MAKE check-manifest
--
2.21.0
4:07 a.m.
On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote:
This ensures that the MANIFEST file is up-to-date, and thus dist
will
(hopefully) work.
Signed-off-by: Pino Toscano <ptoscano(a)redhat.com>
---
guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
jenkins/projects/libvirt-ocaml.yaml | 1 +
2 files changed, 2 insertions(+)
diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml
b/guests/playbooks/build/projects/libvirt-ocaml.yml
index 7a2e216..d293738 100644
--- a/guests/playbooks/build/projects/libvirt-ocaml.yml
+++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
@@ -25,3 +25,4 @@
./configure --prefix=$VIRT_PREFIX
$MAKE
$MAKE opt
+ $MAKE check-manifest
Wouldn't it make sense to have a separate libvirt-ocaml-check job for
this? Also, does libvirt-ocaml have a test suite we could run as part
of that job?
--
Andrea Bolognani / Red Hat / Virtualization
4:13 a.m.
On Tuesday, 3 September 2019 11:07:36 CEST Andrea Bolognani wrote:
On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote:
> This ensures that the MANIFEST file is up-to-date, and thus dist will
> (hopefully) work.
>
> Signed-off-by: Pino Toscano <ptoscano(a)redhat.com>
> ---
> guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
> jenkins/projects/libvirt-ocaml.yaml | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml
b/guests/playbooks/build/projects/libvirt-ocaml.yml
> index 7a2e216..d293738 100644
> --- a/guests/playbooks/build/projects/libvirt-ocaml.yml
> +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
> @@ -25,3 +25,4 @@
> ./configure --prefix=$VIRT_PREFIX
> $MAKE
> $MAKE opt
> + $MAKE check-manifest
Wouldn't it make sense to have a separate libvirt-ocaml-check job for
this?
Right now both the yaml files have a single job doing all the build
commands. Since it uses autoconf but not the rest of autotools, and
it does not support VPATH builds, then I created a simple custom job.
Also, does libvirt-ocaml have a test suite we could run as part
of that job?
Unfortunately not.
--
Pino Toscano
7:01 a.m.
On Tue, 2019-09-03 at 11:13 +0200, Pino Toscano wrote:
On Tuesday, 3 September 2019 11:07:36 CEST Andrea Bolognani wrote:
> On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote:
> > +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
> > @@ -25,3 +25,4 @@
> > ./configure --prefix=$VIRT_PREFIX
> > $MAKE
> > $MAKE opt
> > + $MAKE check-manifest
>
> Wouldn't it make sense to have a separate libvirt-ocaml-check job for
> this?
Right now both the yaml files have a single job doing all the build
commands. Since it uses autoconf but not the rest of autotools, and
it does not support VPATH builds, then I created a simple custom job.
I don't have a problem with custom jobs, it's just that the job is
called libvirt-ocaml-build and what you're doing in the last step is
definitely not building. Adding a libvirt-ocaml-check job, even if
it just checks the manifest for now, makes more sense to me.
Also you mentioned something about RPMs in the commit message... Can
we have a libvirt-ocaml-rpm job?
> Also, does libvirt-ocaml have a test suite we could run as part
> of that job?
Unfortunately not.
Bummer! Someone should work on that ;)
--
Andrea Bolognani / Red Hat / Virtualization
1906
days inactive
1906
days old
3 comments
2 participants
participants (2)
-
Andrea Bolognani -
Pino Toscano