[libvirt] [PATCH] avoid a spurious test failure on non-numa systems

Daniel Veillard spotted this failure, due to a harmless diagnostic: --- expected-err 2008-12-12 16:10:18.000000000 +0100 [16:21] +++ err 2008-12-12 16:10:18.000000000 +0100 @@ -1,2 +1,3 @@ +libnuma: Warning: /sys not mounted or no numa system. Assuming one node: No such file or directory Here's a patch that should make the test ignore that diagnostic. Daniel, if you could test, I'd appreciate it.
From d336426d0127313b014ee453062b342b82ffcf6a Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Fri, 12 Dec 2008 16:38:58 +0100 Subject: [PATCH] avoid a spurious test failure on non-numa systems
* tests/daemon-conf: Ignore a spurious libnuma warning. Reported by Daniel Veillard. --- tests/daemon-conf | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/daemon-conf b/tests/daemon-conf index 03189d5..65a9655 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf @@ -56,8 +56,11 @@ while :; do test $i = $n && break - # Filter out this diagnostic. - sed '/^Cannot set group when not running as root$/d' err > k && mv k err + # Filter out some ignorable diagnostics. + sed \ + -e '/^Cannot set group when not running as root$/d' \ + -e '/^libnuma: Warning: .sys not mounted or no numa system/d' \ + err > k && mv k err printf '%s\n\n' "remoteReadConfigFile: $f: $param_name: $msg" > expected-err diff -u expected-err err || fail=1 -- 1.6.0.4.1044.g77718

On Fri, Dec 12, 2008 at 04:42:49PM +0100, Jim Meyering wrote:
Daniel Veillard spotted this failure, due to a harmless diagnostic:
--- expected-err 2008-12-12 16:10:18.000000000 +0100 [16:21] +++ err 2008-12-12 16:10:18.000000000 +0100 @@ -1,2 +1,3 @@ +libnuma: Warning: /sys not mounted or no numa system. Assuming one node: No such file or directory
Here's a patch that should make the test ignore that diagnostic. Daniel, if you could test, I'd appreciate it.
yes that fixes it on my F-10 laptop, thanks Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

Daniel Veillard <veillard@redhat.com> wrote:
On Fri, Dec 12, 2008 at 04:42:49PM +0100, Jim Meyering wrote:
Daniel Veillard spotted this failure, due to a harmless diagnostic:
--- expected-err 2008-12-12 16:10:18.000000000 +0100 [16:21] +++ err 2008-12-12 16:10:18.000000000 +0100 @@ -1,2 +1,3 @@ +libnuma: Warning: /sys not mounted or no numa system. Assuming one node: No such file or directory
Here's a patch that should make the test ignore that diagnostic. Daniel, if you could test, I'd appreciate it.
yes that fixes it on my F-10 laptop,
Thanks. committed then.
participants (2)
-
Daniel Veillard
-
Jim Meyering