[libvirt] [PATCH] Only build virDomainObjFormat if not building proxy.
While building under RHEL-5, I got a compile warning because virDomainObjFormat was defined but not used. That came about because in RHEL-5 we build with "#define PROXY", and virDomainObjFormat is only used with !PROXY. Move the define. Signed-off-by: Chris Lalancette <clalance@redhat.com> --- src/conf/domain_conf.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b6d2c61..1d7f458 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5668,6 +5668,8 @@ char *virDomainDefFormat(virDomainDefPtr def, return NULL; } +#ifndef PROXY + static char *virDomainObjFormat(virCapsPtr caps, virDomainObjPtr obj, int flags) @@ -5703,9 +5705,6 @@ error: return NULL; } - -#ifndef PROXY - int virDomainSaveXML(const char *configDir, virDomainDefPtr def, const char *xml) -- 1.6.6.1
According to Chris Lalancette on 2/25/2010 12:48 PM:
While building under RHEL-5, I got a compile warning because virDomainObjFormat was defined but not used. That came about because in RHEL-5 we build with "#define PROXY", and virDomainObjFormat is only used with !PROXY. Move the define.
ACK.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Is there a project policy on Signed-off-by lines? According to the git documentation, it only means something if everyone agrees on what it means (on one extreme, the kernel uses it to track that contributions are not license-encumbered, as well as treating it as an audit trail of who has touched the commit; on the other extreme, coreutils avoids it altogether, on the assumption that no one has commit rights without first assigning copyright). Right now, 'git log' makes it look like libvirt's S-o-b usage is ad hoc, according to the contributor's habits. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Thu, Feb 25, 2010 at 04:09:43PM -0700, Eric Blake wrote:
According to Chris Lalancette on 2/25/2010 12:48 PM:
While building under RHEL-5, I got a compile warning because virDomainObjFormat was defined but not used. That came about because in RHEL-5 we build with "#define PROXY", and virDomainObjFormat is only used with !PROXY. Move the define.
ACK.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Is there a project policy on Signed-off-by lines? According to the git
No, it's just an habit of some of us :-), not a formal requirement, [...]
copyright). Right now, 'git log' makes it look like libvirt's S-o-b usage is ad hoc, according to the contributor's habits.
yes, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On 02/25/2010 06:09 PM, Eric Blake wrote:
According to Chris Lalancette on 2/25/2010 12:48 PM:
While building under RHEL-5, I got a compile warning because virDomainObjFormat was defined but not used. That came about because in RHEL-5 we build with "#define PROXY", and virDomainObjFormat is only used with !PROXY. Move the define.
ACK.
Thanks, pushed now.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Is there a project policy on Signed-off-by lines? According to the git documentation, it only means something if everyone agrees on what it means (on one extreme, the kernel uses it to track that contributions are not license-encumbered, as well as treating it as an audit trail of who has touched the commit; on the other extreme, coreutils avoids it altogether, on the assumption that no one has commit rights without first assigning copyright). Right now, 'git log' makes it look like libvirt's S-o-b usage is ad hoc, according to the contributor's habits.
Yeah, as DV said, it's pretty much ad-hoc. I do it out of habit with other projects, and nobody seems to mind :). -- Chris Lalancette
participants (3)
-
Chris Lalancette -
Daniel Veillard -
Eric Blake