[libvirt] [libvirt-test-API][PATCH] Modify makefile to add check option.
Use inspektor to check code style. Change-Id: I8c238c785f8e5dbd585379cad0d4687d0d5b5ce2 Signed-off-by: Ruifeng Bian <rbian@redhat.com> --- Makefile | 3 +++ selftests/check | 15 +++++++++++++++ 2 files changed, 18 insertions(+) create mode 100755 selftests/check diff --git a/Makefile b/Makefile index 91a95db..837f41d 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,9 @@ dist: @echo " " @echo "the archive is $(APP).tar.gz" +check: + selftests/check + clean: @find . -name "*.pyc" -exec rm -f {} \; @rm -rf log/ log.xml diff --git a/selftests/check b/selftests/check new file mode 100755 index 0000000..f064651 --- /dev/null +++ b/selftests/check @@ -0,0 +1,15 @@ +#!/bin/bash +ret=0 +run_cmd() { + echo "Running '$1'" + $1 + if [ $? != 0 ]; then + ret=1 + fi + echo "" +} +run_cmd 'inspekt lint' +run_cmd 'inspekt indent' +run_cmd 'inspekt style' +exit ${ret} + -- 2.4.3
ACK Liping ----- Original Message ----- From: "Ruifeng Bian" <rbian@redhat.com> To: libvir-list@redhat.com Cc: "Ruifeng Bian" <rbian@redhat.com> Sent: Wednesday, June 29, 2016 5:01:26 PM Subject: [libvirt] [libvirt-test-API][PATCH] Modify makefile to add check option. Use inspektor to check code style. Change-Id: I8c238c785f8e5dbd585379cad0d4687d0d5b5ce2 Signed-off-by: Ruifeng Bian <rbian@redhat.com> --- Makefile | 3 +++ selftests/check | 15 +++++++++++++++ 2 files changed, 18 insertions(+) create mode 100755 selftests/check diff --git a/Makefile b/Makefile index 91a95db..837f41d 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,9 @@ dist: @echo " " @echo "the archive is $(APP).tar.gz" +check: + selftests/check + clean: @find . -name "*.pyc" -exec rm -f {} \; @rm -rf log/ log.xml diff --git a/selftests/check b/selftests/check new file mode 100755 index 0000000..f064651 --- /dev/null +++ b/selftests/check @@ -0,0 +1,15 @@ +#!/bin/bash +ret=0 +run_cmd() { + echo "Running '$1'" + $1 + if [ $? != 0 ]; then + ret=1 + fi + echo "" +} +run_cmd 'inspekt lint' +run_cmd 'inspekt indent' +run_cmd 'inspekt style' +exit ${ret} + -- 2.4.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
----- Original Message -----
From: "Liping Cheng" <lcheng@redhat.com> To: "Ruifeng Bian" <rbian@redhat.com> Cc: libvir-list@redhat.com Sent: Wednesday, June 29, 2016 6:16:23 PM Subject: Re: [libvirt] [libvirt-test-API][PATCH] Modify makefile to add check option.
ACK
Liping
Thanks, pushed.
----- Original Message ----- From: "Ruifeng Bian" <rbian@redhat.com> To: libvir-list@redhat.com Cc: "Ruifeng Bian" <rbian@redhat.com> Sent: Wednesday, June 29, 2016 5:01:26 PM Subject: [libvirt] [libvirt-test-API][PATCH] Modify makefile to add check option.
Use inspektor to check code style.
Change-Id: I8c238c785f8e5dbd585379cad0d4687d0d5b5ce2 Signed-off-by: Ruifeng Bian <rbian@redhat.com> --- Makefile | 3 +++ selftests/check | 15 +++++++++++++++ 2 files changed, 18 insertions(+) create mode 100755 selftests/check
diff --git a/Makefile b/Makefile index 91a95db..837f41d 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,9 @@ dist: @echo " " @echo "the archive is $(APP).tar.gz"
+check: + selftests/check + clean: @find . -name "*.pyc" -exec rm -f {} \; @rm -rf log/ log.xml diff --git a/selftests/check b/selftests/check new file mode 100755 index 0000000..f064651 --- /dev/null +++ b/selftests/check @@ -0,0 +1,15 @@ +#!/bin/bash +ret=0 +run_cmd() { + echo "Running '$1'" + $1 + if [ $? != 0 ]; then + ret=1 + fi + echo "" +} +run_cmd 'inspekt lint' +run_cmd 'inspekt indent' +run_cmd 'inspekt style' +exit ${ret} + -- 2.4.3
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Liping Cheng -
Ruifeng Bian