[PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst
Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) -- 2.25.1
Changing the introduction to bring the idea of this document better across. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> --- docs/pci-addresses.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 1d2dc8e5fc..7c8e9edd73 100644 --- a/docs/pci-addresses.rst +++ b/docs/pci-addresses.rst @@ -4,9 +4,12 @@ PCI addresses in domain XML and guest OS .. contents:: -When discussing PCI addresses, it's important to understand the -relationship between the addresses that can be seen in the domain XML -and those that are visible inside the guest OS. +Looking at the configuration for a guest, it would be reasonable +to expect that each PCI device would show up in the guest OS with +a PCI address that matches the one present in the corresponding +``<address>`` element of the domain XML, but that's not guaranteed +to happen and will in fact not be the case in all but the simplest +scenarios. Simple cases -- 2.25.1
Improving the zPCI example by choosing more distinct values and adding explanation for fid. Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com> --- docs/pci-addresses.rst | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 7c8e9edd73..885d50517a 100644 --- a/docs/pci-addresses.rst +++ b/docs/pci-addresses.rst @@ -176,14 +176,14 @@ In the simplest case, the following XML snippet <model name='pci-bridge'/> <target chassisNr='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'> - <zpci uid='0x0002' fid='0x00000001'/> + <zpci uid='0x0001' fid='0x00000000'/> </address> </controller> <interface type='bridge'> <source bridge='virbr0'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'> - <zpci uid='0x0001' fid='0x00000000'/> + <zpci uid='0x0007' fid='0x00000003'/> </address> </interface> @@ -191,21 +191,23 @@ will result in the following in a Linux guest: :: - 0001:00:00.0 Ethernet controller: Red Hat, Inc. Virtio network device + 0007:00:00.0 Ethernet controller: Red Hat, Inc. Virtio network device Note that the PCI bridge is not visible in the guest; s390x always has a flat -topology. +topology. The PCI address in the guest is generated from the information +provided via the ``zpci`` element: more specifically, ``uid`` is used as the +PCI domain. ``fid`` doesn't appear in the PCI address itself, but it will be +used in sysfs (``/sys/bus/pci/slots/$fid/...``). -Neither are any changes in the PCI address visible in the guest; replacing -the PCI address for the ``virtio-net`` device with +Any changes in the PCI address are not visible in the guest; replacing the PCI +address for the ``virtio-net`` device with :: - <address type='pci' domain='0x0000' bus='0x01' slot='0x07' function='0x3'> + <address type='pci' domain='0x0000' bus='0x01' slot='0x06' function='0x4'> -will result in the exactly same view in the guest, as the addresses there -are generated from the information provided via the ``zpci`` element (in -fact, from the ``uid``). +will result in the exactly same view in the guest, as the ``fid`` and ``uid`` +values in the ``zpci`` element remain unchanged. Device assignment -- 2.25.1
On Fri, 17 Apr 2020 14:27:34 +0200 Boris Fiuczynski <fiuczy@linux.ibm.com> wrote:
Improving the zPCI example by choosing more distinct values and adding explanation for fid.
Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com> --- docs/pci-addresses.rst | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On Fri, 2020-04-17 at 14:27 +0200, Boris Fiuczynski wrote:
Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst
docs/pci-addresses.rst | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-)
Series Reviewed-by: Andrea Bolognani <abologna@redhat.com> and pushed. Thank you both for your contributions and your patience :) -- Andrea Bolognani / Red Hat / Virtualization
On 4/17/20 3:06 PM, Andrea Bolognani wrote:
On Fri, 2020-04-17 at 14:27 +0200, Boris Fiuczynski wrote:
Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst
docs/pci-addresses.rst | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-)
Series
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
and pushed.
Thank you both for your contributions and your patience :)
Thanks for pushing the changes and your patience. Have a nice weekend. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (3)
-
Andrea Bolognani -
Boris Fiuczynski -
Cornelia Huck