Signed-off-by: Li Yang <liyang.fnst@cn.fujitsu.com> --- src/datatypes.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index 9621c55..3bc2420 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -469,7 +469,7 @@ struct _virNodeDevice { struct _virSecret { virObject object; virConnectPtr conn; /* pointer back to the connection */ - unsigned char uuid[VIR_UUID_BUFLEN]; /* the domain unique identifier */ + unsigned char uuid[VIR_UUID_BUFLEN]; /* the secret unique identifier */ int usageType; /* the type of usage */ char *usageID; /* the usage's unique identifier */ }; -- 1.7.1

On 04/28/2014 08:10 PM, Li Yang wrote:

Signed-off-by: Li Yang <liyang.fnst@cn.fujitsu.com> --- tools/virsh-secret.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 47974fe..e996c72 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -558,7 +558,7 @@ cmdSecretList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED)

Additional context: for (i = 0; i < list->nsecrets; i++) { virSecretPtr sec = list->secrets[i];

const char *usageStr = virSecretUsageTypeTypeToString(usageType); char uuid[VIR_UUID_STRING_BUFLEN];

- if (virSecretGetUUIDString(list->secrets[i], uuid) < 0) { + if (virSecretGetUUIDString(sec, uuid) < 0) {

No semantic difference. But doesn't hurt, so ACK and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org