On 08/16/2010 10:15 AM, Daniel P. Berrange wrote:
On Fri, Aug 13, 2010 at 05:00:31PM -0500, Jamie Strandboge wrote:
> Attached is 0004-apparmor-fix-warn.patch
>
> --
> Jamie Strandboge |
http://www.canonical.com
> diff -Naurp libvirt.orig/src/security/virt-aa-helper.c
libvirt/src/security/virt-aa-helper.c
> --- libvirt.orig/src/security/virt-aa-helper.c 2010-08-13 16:23:44.000000000 -0500
> +++ libvirt/src/security/virt-aa-helper.c 2010-08-13 16:49:27.000000000 -0500
> @@ -19,6 +19,7 @@
> #include <unistd.h>
> #include <errno.h>
> #include <sys/types.h>
> +#include <sys/stat.h>
> #include <fcntl.h>
> #include <getopt.h>
> #include <stdbool.h>
ACK
This one is independently useful, so I've pushed it in your name after
inventing a trivial commit message. For the others, I'll wait for a
repost that includes the commit message and resolves Daniel's concerns.
Also, when posting a patch series, it is helpful if all of the patches
in the series are sent in-reply-to the cover letter (in my particular
case, I have my mail client preferences set to display threads in order
of most recent activity, so when a patch series is not threaded, it
means that a reply to one patch in the series makes it harder to find
the rest of the emails related to the series since they are no longer
adjacent). Using 'git send-email' can make sending a properly-threaded
patch series easier to achieve.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org