[libvirt] [PATCH] Remove bogus ATTRIBUTE_NONNULL from virFirewallAddRuleFull

The virFirewallAddRuleFull method originally had a single compulsory virFirewallQueryCallback parameter. During dev work though the ignoreErrors parameter was added and the callback parameter made optional. The ATTRIBUTE_NONNULL annotation was never removed though. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/util/virfirewall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h index 5ca66fa..1129219 100644 --- a/src/util/virfirewall.h +++ b/src/util/virfirewall.h @@ -59,7 +59,7 @@ virFirewallRulePtr virFirewallAddRuleFull(virFirewallPtr firewall, virFirewallQueryCallback cb, void *opaque, ...) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_SENTINEL; + ATTRIBUTE_SENTINEL; void virFirewallRemoveRule(virFirewallPtr firewall, virFirewallRulePtr rule); -- 1.9.0

On 04/28/2014 09:18 AM, Daniel P. Berrange wrote:
The virFirewallAddRuleFull method originally had a single compulsory virFirewallQueryCallback parameter. During dev work though the ignoreErrors parameter was added and the callback parameter made optional. The ATTRIBUTE_NONNULL annotation was never removed though.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/util/virfirewall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK - this makes coverity build happy again. John
participants (2)
-
Daniel P. Berrange
-
John Ferlan