[libvirt] [PATCH] tests: skip schema validation tests if xmllint is missing
On IRC, someone complained that a system without xmllint installed failed a number of tests. * tests/schematestutils.sh: Probe for xmllint. Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/schematestutils.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index e594f04..a0ff77e 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -1,5 +1,7 @@ #!/bin/sh +(xmllint --version) >/dev/null 2>&1 || skip_test_ 'Missing xmllint' + check_schema () { DIRS=$1 -- 1.8.3.1
On 23/08/13 04:08, Eric Blake wrote:
On IRC, someone complained that a system without xmllint installed failed a number of tests.
* tests/schematestutils.sh: Probe for xmllint.
Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/schematestutils.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index e594f04..a0ff77e 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -1,5 +1,7 @@ #!/bin/sh
+(xmllint --version) >/dev/null 2>&1 || skip_test_ 'Missing xmllint' + check_schema () {
DIRS=$1
ACK.
On 08/22/2013 08:43 PM, Osier Yang wrote:
On 23/08/13 04:08, Eric Blake wrote:
On IRC, someone complained that a system without xmllint installed failed a number of tests.
* tests/schematestutils.sh: Probe for xmllint.
Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/schematestutils.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index e594f04..a0ff77e 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -1,5 +1,7 @@ #!/bin/sh
+(xmllint --version) >/dev/null 2>&1 || skip_test_ 'Missing xmllint' + check_schema () {
DIRS=$1
ACK.
Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Osier Yang