On Mon, Aug 24, 2009 at 01:43:56PM +0200, Pritesh Kothari wrote:
Hi,
There is a bug in virsh command vol-key, it segfaults cause the fourth option
to vshCommandOptVolBy() is null instead of "pool" on virsh.c:5209.
The patch to fix this is attached.
Thanks, will apply this shortly
Daniel
diff --git a/src/virsh.c b/src/virsh.c
index 2d0cf81..15e0cef 100644
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -5206,7 +5206,7 @@ cmdVolKey(vshControl *ctl, const vshCmd *cmd)
if (!vshConnectionUsability(ctl, ctl->conn, TRUE))
return FALSE;
- if (!(vol = vshCommandOptVolBy(ctl, cmd, "vol", NULL, NULL,
+ if (!(vol = vshCommandOptVolBy(ctl, cmd, "vol", "pool", NULL,
VSH_BYUUID)))
return FALSE;
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://ovirt.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|