Re: [libvirt] Request to mailing list libvir-list rejected

[in general, technical lists tend to frown on the practice of top-posting] On 03/10/2010 02:49 PM, Dev.Atom wrote:
Sorry, I'm not used to use mailing list
I think the relevants part are these functions :
int virFileOperation(const char *path, int openflags, mode_t mode, uid_t uid, gid_t gid, virFileOperationHook hook, void *hookdata, unsigned int flags) __attribute__((__warn_unused_result__));
int virDirCreate(const char *path, mode_t mode, uid_t uid, gid_t gid, unsigned int flags) __attribute__((__warn_unused_result__));
Yes, my request was not to dump the entire (750k) preprocessor output to the list, but to just the relevant portion of the output to make sure there weren't any macros interfering with the parse.
Matthias say that he has patches which will be ready in the week, and I can wait for these patches
Matthias probably already hit it on the head - gnulib can guarantee that uid_t is defined in spite of mingw not providing it, but I haven't personally checked whether we are using this aspect of gnulib yet, and I will defer to see Matthias' patches. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

2010/3/10 Eric Blake <eblake@redhat.com>:
[in general, technical lists tend to frown on the practice of top-posting]
On 03/10/2010 02:49 PM, Dev.Atom wrote:
Sorry, I'm not used to use mailing list
I think the relevants part are these functions :
int virFileOperation(const char *path, int openflags, mode_t mode, uid_t uid, gid_t gid, virFileOperationHook hook, void *hookdata, unsigned int flags) __attribute__((__warn_unused_result__));
int virDirCreate(const char *path, mode_t mode, uid_t uid, gid_t gid, unsigned int flags) __attribute__((__warn_unused_result__));
Yes, my request was not to dump the entire (750k) preprocessor output to the list, but to just the relevant portion of the output to make sure there weren't any macros interfering with the parse.
Matthias say that he has patches which will be ready in the week, and I can wait for these patches
Matthias probably already hit it on the head - gnulib can guarantee that uid_t is defined in spite of mingw not providing it, but I haven't personally checked whether we are using this aspect of gnulib yet, and I will defer to see Matthias' patches.
Well, I looked at gnulib, but I can't find where or how it guarantees uid_t and gid_t. But just having uid_t and gid_t defines doesn't help that much if the related functions like chown are missing. I ended up just adding typedef unsigned int uid_t. Matthias

On 03/12/2010 09:13 AM, Matthias Bolte wrote:
Matthias probably already hit it on the head - gnulib can guarantee that uid_t is defined in spite of mingw not providing it, but I haven't personally checked whether we are using this aspect of gnulib yet, and I will defer to see Matthias' patches.
Well, I looked at gnulib, but I can't find where or how it guarantees uid_t and gid_t. But just having uid_t and gid_t defines doesn't help that much if the related functions like chown are missing.
Gnulib also provides a replacement chown for mingw (yes, the replacement always fails with ENOSYS, but at least it doesn't cause link failures).
I ended up just adding typedef unsigned int uid_t.
You can get that for free by using the gnulib chown replacement, or by using AC_REQUIRE([AC_TYPE_UID_T]) in configure.ac. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake
-
Matthias Bolte