[libvirt] [PATCH] rename "blocked" to "idle"
<movement> can we please please rename "blocked" to "idle" <movement> literally /everybody/ is confused by that ... <dansmith> I'm not opposed to changing it, mind you, because I feel the indirect pain of explaining it to others too :) <movement> actually, normally, the question is "my guest isn't running" <dansmith> yeah regards john Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.163 diff -r1.163 virsh.c 6275c6275 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
6297c6297 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
On Fri, Sep 12, 2008 at 05:10:38PM +0100, John Levon wrote:
Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.163 diff -r1.163 virsh.c 6275c6275 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
6297c6297 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
Yes, I agree, although maybe it'll confuse people looking at the actual states in the header files or whatever. +1? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/
On Mon, Sep 15, 2008 at 12:40:14PM +0100, Richard W.M. Jones wrote:
diff -r1.163 virsh.c 6275c6275 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
6297c6297 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
Yes, I agree, although maybe it'll confuse people looking at the actual states in the header files or whatever.
I think anyone actually programming to libvirt would be much more likely to understand what "blocked" really means, though. regards john
On Fri, Sep 12, 2008 at 05:10:38PM +0100, John Levon wrote:
<movement> can we please please rename "blocked" to "idle" <movement> literally /everybody/ is confused by that ...
<dansmith> I'm not opposed to changing it, mind you, because I feel the indirect pain of explaining it to others too :) <movement> actually, normally, the question is "my guest isn't running" <dansmith> yeah
regards john
Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.163 diff -r1.163 virsh.c 6275c6275 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
6297c6297 < return gettext_noop("blocked"); ---
return gettext_noop("idle");
Thanks, I've applied this to CVS. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
On Wed, Sep 17, 2008 at 03:15:14PM +0100, Richard W.M. Jones wrote:
On Fri, Sep 12, 2008 at 05:10:38PM +0100, John Levon wrote:
<movement> can we please please rename "blocked" to "idle" <movement> literally /everybody/ is confused by that ...
<dansmith> I'm not opposed to changing it, mind you, because I feel the indirect pain of explaining it to others too :) <movement> actually, normally, the question is "my guest isn't running" <dansmith> yeah
I still think "blocked" might make more sense. If the domain is doing I/O it will be most of gthe time blocked until the I/O completes and I guess it's the reason of the naming. It's just unfortunate that we can't distinguish between blocked on I/O and being idle. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel Veillard -
John Levon -
Richard W.M. Jones