[PATCH 0/2] virt-host-validate-bhyve: Improve checks
Nimish Jain (2): replace if_tap check with if_tuntap check add pf check tools/virt-host-validate-bhyve.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.39.5 (Apple Git-154)
if_tap is now bundled with if_tuntap, so we replace that check. Signed-off-by: Nimish Jain <unauthorizen@gmail.com> --- tools/virt-host-validate-bhyve.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bhyve.c index d7a409db9d..9bc958445e 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -22,6 +22,7 @@ #include <config.h> #include <sys/param.h> +#include <sys/module.h> #include <sys/linker.h> #include "virt-host-validate-bhyve.h" @@ -62,14 +63,15 @@ int virHostValidateBhyve(void) if (STREQ(stat->name, "vmm.ko")) vmm_loaded = true; - else if (STREQ(stat->name, "if_tap.ko")) - if_tap_loaded = true; else if (STREQ(stat->name, "if_bridge.ko")) if_bridge_loaded = true; else if (STREQ(stat->name, "nmdm.ko")) nmdm_loaded = true; } + if (modfind("if_tuntap") > 0) + if_tap_loaded = true; + MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); MODULE_STATUS_WARN(if_tap, "networking will not work"); MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); -- 2.39.5 (Apple Git-154)
pf is needed for network driver to pass packets to the VM Signed-off-by: Nimish Jain <unauthorizen@gmail.com> --- tools/virt-host-validate-bhyve.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bhyve.c index 9bc958445e..bbb4a691b6 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -55,6 +55,7 @@ int virHostValidateBhyve(void) bool if_tap_loaded = false; bool if_bridge_loaded = false; bool nmdm_loaded = false; + bool pf_loaded = false; for (fileid = kldnext(0); fileid > 0; fileid = kldnext(fileid)) { stat->version = sizeof(struct kld_file_stat); @@ -67,6 +68,8 @@ int virHostValidateBhyve(void) if_bridge_loaded = true; else if (STREQ(stat->name, "nmdm.ko")) nmdm_loaded = true; + else if (STREQ(stat->name, "pf.ko")) + pf_loaded = true; } if (modfind("if_tuntap") > 0) @@ -74,6 +77,7 @@ int virHostValidateBhyve(void) MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); MODULE_STATUS_WARN(if_tap, "networking will not work"); + MODULE_STATUS_WARN(pf, "pf firewall backend will not work"); MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); MODULE_STATUS_WARN(nmdm, "nmdm console will not work"); -- 2.39.5 (Apple Git-154)
Nimish Jain wrote:
Nimish Jain (2): replace if_tap check with if_tuntap check add pf check
tools/virt-host-validate-bhyve.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
-- 2.39.5 (Apple Git-154)
Series: Reviewed-by: Roman Bogorodskiy <bogorodskiy@gmail.com> I have slightly updated the commit messages, mainly the first one to give more details about if_tap -> if_tuntap rename, and pushed the series. Congrats on the first libvirt contribution!
participants (2)
-
Nimish Jain -
Roman Bogorodskiy