[libvirt] [PATCH] Remove bash-ism from tests/schematestutils.sh
Remove bash-ism from tests/schematestutils.sh Fix a bash-ism in an sh script, introduced by commit a3f71eb Signed-off-by: Chris Dunlop <chris@onthe.net.au> diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index e739b99..c34364f 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -20,7 +20,7 @@ do result=`$cmd 2>&1` ret=$? - grep -- '-invalid.xml$' <<< "$xml" 2>&1 >/dev/null + echo "$xml" | grep -- '-invalid.xml$' 2>&1 >/dev/null invalid=$? # per xmllint man page, the return codes for validation error
On 05/17/2013 09:03 PM, Chris Dunlop wrote:
Remove bash-ism from tests/schematestutils.sh
Fix a bash-ism in an sh script, introduced by commit a3f71eb
NACK. a3f71eb is on the v1.0.5-maint branch; maint branches should only use backports from the mainstream branch to avoid introducing regressions when upgrading from a maint release to a newer upstream release. Instead, what needs to be done is backporting commit 1d21b88, which fixed the problem in a more elegant way on the mainline branch, into v1.0.5-maint. So I've done that. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Chris Dunlop -
Eric Blake