Re: [Libvir] [patch 7/9] Add support for lokkit
+AC_ARG_ENABLE(iptables-lokkit, Just a minor nit here: My reading of the autoconf info page is that this should be a --with argument, not an --enable argument. [...] Optional Features: ... --enable-bar include bar Optional Packages: ... --with-foo use foo [...] 14.2 Working With External Software =================================== Some packages require, or can optionally use, other software packages that are already installed. The user can give `configure' command line options to specify which such external software to use. The options have one of these forms: --with-PACKAGE[=ARG] --without-PACKAGE [...] 14.3 Choosing Package Options ============================= If a software package has optional compile-time features, the user can give `configure' command line options to specify whether to compile them. The options have one of these forms: --enable-FEATURE[=ARG] --disable-FEATURE Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Hi Rich, On Mon, 2008-01-14 at 12:13 +0000, Richard W.M. Jones wrote:
Just a minor nit here: My reading of the autoconf info page is that this should be a --with argument, not an --enable argument.
I don't mind either way, but my understanding was that --with would only be appropriate if we were doing: --with-lokkit=/usr/sbin/lokkit i.e. that --with was used for specifying the location of some external dependency, whereas --enable is used for simply enabling or disabling a feature. Cheers, Mark.
Mark McLoughlin wrote:
Hi Rich,
On Mon, 2008-01-14 at 12:13 +0000, Richard W.M. Jones wrote:
Just a minor nit here: My reading of the autoconf info page is that this should be a --with argument, not an --enable argument.
I don't mind either way, but my understanding was that --with would only be appropriate if we were doing:
--with-lokkit=/usr/sbin/lokkit
i.e. that --with was used for specifying the location of some external dependency, whereas --enable is used for simply enabling or disabling a feature.
You could be right. /me invokes Jim Meyering ... https://www.redhat.com/archives/libvir-list/2008-January/msg00126.html Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
"Richard W.M. Jones" <rjones@redhat.com> wrote:
Mark McLoughlin wrote:
Hi Rich,
On Mon, 2008-01-14 at 12:13 +0000, Richard W.M. Jones wrote:
Just a minor nit here: My reading of the autoconf info page is that this should be a --with argument, not an --enable argument.
I don't mind either way, but my understanding was that --with would only be appropriate if we were doing:
--with-lokkit=/usr/sbin/lokkit
i.e. that --with was used for specifying the location of some external dependency, whereas --enable is used for simply enabling or disabling a feature.
You could be right.
/me invokes Jim Meyering ... https://www.redhat.com/archives/libvir-list/2008-January/msg00126.html
Hi guys, You probably know that --with-THING and --enable-THING are functionally equivalent, and the question is about which should appear in "./configure --help" output. The autoconf documentation describes the distinction between --with-PACKAGE and --enable-FEATURE, but since lokkit is a package, and "lokkit-support" can be considered a feature of libvirt, it's a little ambiguous. However, since autoconf gives the examples of "--with-x" and "--with-gnu-as", "--with-lokkit" does seem to be more in line.
On Mon, Jan 14, 2008 at 02:00:36PM +0100, Jim Meyering wrote:
"Richard W.M. Jones" <rjones@redhat.com> wrote:
Mark McLoughlin wrote:
Hi Rich,
On Mon, 2008-01-14 at 12:13 +0000, Richard W.M. Jones wrote:
Just a minor nit here: My reading of the autoconf info page is that this should be a --with argument, not an --enable argument.
I don't mind either way, but my understanding was that --with would only be appropriate if we were doing:
--with-lokkit=/usr/sbin/lokkit
i.e. that --with was used for specifying the location of some external dependency, whereas --enable is used for simply enabling or disabling a feature.
You could be right.
/me invokes Jim Meyering ... https://www.redhat.com/archives/libvir-list/2008-January/msg00126.html
Hi guys,
You probably know that --with-THING and --enable-THING are functionally equivalent, and the question is about which should appear in "./configure --help" output.
The autoconf documentation describes the distinction between --with-PACKAGE and --enable-FEATURE, but since lokkit is a package, and "lokkit-support" can be considered a feature of libvirt, it's a little ambiguous.
However, since autoconf gives the examples of "--with-x" and "--with-gnu-as", "--with-lokkit" does seem to be more in line.
Yep, I think we should use --with-lokkit since it also fits it a little better with the other --with-PROG args we already have - even though they don't all take a path as their optional arg (yet). Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (4)
-
Daniel P. Berrange -
Jim Meyering -
Mark McLoughlin -
Richard W.M. Jones