[Libvir] Patch for pkg-config file cflags
The libvirt.pc.in file has an empty field for the cflags variable, so if you install libvirt into any prefix which is not in the compiler's default include file search path the header files won't be found when compiling applications. Attching a patch which corrects the pkg-config file for libvirt Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Thu, Mar 23, 2006 at 10:09:37PM +0000, Daniel P. Berrange wrote:
The libvirt.pc.in file has an empty field for the cflags variable, so if you install libvirt into any prefix which is not in the compiler's default include file search path the header files won't be found when compiling applications. Attching a patch which corrects the pkg-config file for libvirt [...] -Cflags: +Cflags: -I${includedir}
Hummm, true, that's a problem. But this patch leads to adding -I/usr/include to the PATH used when compiling on a normal setup where libvirt is installed with the system in the /usr prefix. I think this is not a good idea in general so that need to be avoided in that case. I'm not sure if pkgconfig is smart enough to strip it out or if this should be done at genration time, i.e. in configure. Okay I checked and pkg-config removes it on the fly, so patch applied, thanks ! Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel P. Berrange -
Daniel Veillard