[libvirt] [PATCH 2/2] Add --source-format argument to virsh pool-define-as and pool-create-as
This is the corresponding patch for the virsh man page (virsh.pod). It's diff-d against present git master. Regards and best wishes, Justin Clift -- Salasaga - Open Source eLearning IDE http://www.salasaga.org
On 05/30/2010 10:24 AM, Justin Clift wrote:
This is the corresponding patch for the virsh man page (virsh.pod).
It's diff-d against present git master.
Regards and best wishes,
Justin Clift
diff --git a/tools/virsh.pod b/tools/virsh.pod index cf7585d..3bf79d5 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -667,7 +667,7 @@ Build a given pool. Create and start a pool object from the XML I<file>.
=item B<pool-create-as> I<name> I<--print-xml> I<type> optional I<source-host> -I<source-path> I<source-dev> I<source-name> <target> +I<source-path> I<source-dev> I<source-name> <target> I<--source-format format>
Create and start a pool object I<name> from the raw parameters. If I<--print-xml> is specified, then print the XML of the pool object @@ -679,7 +679,7 @@ I<type>. Create, but do not start, a pool object from the XML I<file>.
=item B<pool-define-as> I<name> I<--print-xml> I<type> optional I<source-host> -I<source-path> I<source-dev> I<source-name> <target> +I<source-path> I<source-dev> I<source-name> <target> I<--source-format format>
Create, but do not start, a pool object I<name> from the raw parameters. If I<--print-xml> is specified, then print the XML of the pool object
ACK - Cole
On 06/01/2010 09:50 AM, Cole Robinson wrote:
On 05/30/2010 10:24 AM, Justin Clift wrote:
Also created a Red Hat BZ ticket for this (#597790) for tracking.
This is the corresponding patch for the virsh man page (virsh.pod).
ACK
Second that. And *kudos* to you for updating the documentation along with the implementation, as well as creating the corresponding BZ! If only all first-time contributor bug reports were this nice! Pushed both patches. My only suggestion for the future is to use 'git format-patch' or 'git send-email', so that your commit message is preserved intact, rather than just attaching the 'git diff' output, so that I don't have to trim your entire email body down into a commit message. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 06/02/2010 08:59 AM, Eric Blake wrote:
On 06/01/2010 09:50 AM, Cole Robinson wrote:
On 05/30/2010 10:24 AM, Justin Clift wrote:
Also created a Red Hat BZ ticket for this (#597790) for tracking.
This is the corresponding patch for the virsh man page (virsh.pod).
ACK
Second that. And *kudos* to you for updating the documentation along with the implementation, as well as creating the corresponding BZ! If only all first-time contributor bug reports were this nice! Pushed both patches. My only suggestion for the future is to use 'git format-patch' or 'git send-email', so that your commit message is preserved intact, rather than just attaching the 'git diff' output, so that I don't have to trim your entire email body down into a commit message.
Interesting, thanks. New to git, and learning as I go. :) Regards and best wishes, Justin Clift -- Salasaga - Open Source eLearning IDE http://www.salasaga.org
participants (3)
-
Cole Robinson -
Eric Blake -
Justin Clift