[libvirt] [perl PATCH 0/2] Rename IOThreads* APIs to IOThread
These depend on the rename being pushed to libvirt.git: (first four patches of:) https://www.redhat.com/archives/libvir-list/2015-March/msg01325.html Ján Tomko (2): Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo Changes | 2 ++ Virt.xs | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.0.5
--- Changes | 1 + Virt.xs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index 017990a..44a42f2 100644 --- a/Changes +++ b/Changes @@ -9,6 +9,7 @@ Revision history for perl module Sys::Virt - Add VIR_DOMAIN_TUNABLE_CPU_IOTHREADSPIN constant - Add virDomainInterfaceAddress function & constants - Add VIR_DOMAIN_PAUSED_STARTING_UP constant + - Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree 1.2.13 2015-03-05 diff --git a/Virt.xs b/Virt.xs index 35ea013..5dc977a 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5039,7 +5039,7 @@ get_iothread_info(dom, flags=0) } for (i = 0 ; i < niothreads ; i++) { - virDomainIOThreadsInfoFree(iothrinfo[i]); + virDomainIOThreadInfoFree(iothrinfo[i]); } free(iothrinfo); -- 2.0.5
--- Changes | 1 + Virt.xs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 44a42f2..7a2bc51 100644 --- a/Changes +++ b/Changes @@ -10,6 +10,7 @@ Revision history for perl module Sys::Virt - Add virDomainInterfaceAddress function & constants - Add VIR_DOMAIN_PAUSED_STARTING_UP constant - Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree + - Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo 1.2.13 2015-03-05 diff --git a/Virt.xs b/Virt.xs index 5dc977a..2138530 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5023,8 +5023,8 @@ get_iothread_info(dom, flags=0) int niothreads; int i; PPCODE: - if ((niothreads = virDomainGetIOThreadsInfo(dom, &iothrinfo, - flags)) < 0) + if ((niothreads = virDomainGetIOThreadInfo(dom, &iothrinfo, + flags)) < 0) _croak_error(); EXTEND(SP, niothreads); -- 2.0.5
On 03/26/2015 08:46 AM, Ján Tomko wrote:
--- Changes | 1 + Virt.xs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
There's also examples/iothreadsinfo.pl that needs to be updated - not only to have the right API name, but to add the CPU Time if you added that as well John
diff --git a/Changes b/Changes index 44a42f2..7a2bc51 100644 --- a/Changes +++ b/Changes @@ -10,6 +10,7 @@ Revision history for perl module Sys::Virt - Add virDomainInterfaceAddress function & constants - Add VIR_DOMAIN_PAUSED_STARTING_UP constant - Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree + - Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo
1.2.13 2015-03-05
diff --git a/Virt.xs b/Virt.xs index 5dc977a..2138530 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5023,8 +5023,8 @@ get_iothread_info(dom, flags=0) int niothreads; int i; PPCODE: - if ((niothreads = virDomainGetIOThreadsInfo(dom, &iothrinfo, - flags)) < 0) + if ((niothreads = virDomainGetIOThreadInfo(dom, &iothrinfo, + flags)) < 0) _croak_error();
EXTEND(SP, niothreads);
On Thu, Mar 26, 2015 at 11:42:12AM -0400, John Ferlan wrote:
On 03/26/2015 08:46 AM, Ján Tomko wrote:
--- Changes | 1 + Virt.xs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
There's also examples/iothreadsinfo.pl that needs to be updated - not only to have the right API name, but to add the CPU Time if you added that as well
The perl API name has not changed. Jan
John
diff --git a/Changes b/Changes index 44a42f2..7a2bc51 100644 --- a/Changes +++ b/Changes @@ -10,6 +10,7 @@ Revision history for perl module Sys::Virt - Add virDomainInterfaceAddress function & constants - Add VIR_DOMAIN_PAUSED_STARTING_UP constant - Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree + - Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo
1.2.13 2015-03-05
diff --git a/Virt.xs b/Virt.xs index 5dc977a..2138530 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5023,8 +5023,8 @@ get_iothread_info(dom, flags=0) int niothreads; int i; PPCODE: - if ((niothreads = virDomainGetIOThreadsInfo(dom, &iothrinfo, - flags)) < 0) + if ((niothreads = virDomainGetIOThreadInfo(dom, &iothrinfo, + flags)) < 0) _croak_error();
EXTEND(SP, niothreads);
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 03/26/2015 08:46 AM, Ján Tomko wrote:
These depend on the rename being pushed to libvirt.git: (first four patches of:) https://www.redhat.com/archives/libvir-list/2015-March/msg01325.html
Ján Tomko (2): Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo
Changes | 2 ++ Virt.xs | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-)
Well unless you feel the need to rename the examples/iothreadsinfo.pl examples/iothreadinfo.pl ... ACK - John
On Fri, Mar 27, 2015 at 05:17:08PM -0400, John Ferlan wrote:
On 03/26/2015 08:46 AM, Ján Tomko wrote:
These depend on the rename being pushed to libvirt.git: (first four patches of:) https://www.redhat.com/archives/libvir-list/2015-March/msg01325.html
Ján Tomko (2): Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo
Changes | 2 ++ Virt.xs | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-)
Well unless you feel the need to rename the examples/iothreadsinfo.pl examples/iothreadinfo.pl ...
I completely overlooked that.
ACK -
Thanks, pushed now. Jan
participants (2)
-
John Ferlan -
Ján Tomko