[libvirt] [PATCH python 0/2] spec: fedora tweaks
Some fedora version tweaks Cole Robinson (2): spec: Unconditionally build python2 on Fedora spec: Bump minimum supported Fedora version to 29 libvirt-python.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.21.0
In Fedora we are currently shipping python2 bindings for all builds, so this conditional is out of date. Fedora 31 may be the time that python2 bindings are dropped: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal But I think it's better to wait for that to actually happen before we change this again Signed-off-by: Cole Robinson <crobinso@redhat.com> --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 136c4ad..69d7555 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -13,7 +13,7 @@ %endif %define _with_python2 1 -%if 0%{?fedora} > 29 || 0%{?rhel} > 7 +%if 0%{?fedora} || 0%{?rhel} > 7 %define _with_python2 0 %endif -- 2.21.0
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 69d7555..64a30b5 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -4,7 +4,7 @@ # that's still supported by the vendor. It may work on other distros # or versions, but no effort will be made to ensure that going forward %define min_rhel 7 -%define min_fedora 27 +%define min_fedora 29 %if (0%{?fedora} && 0%{?fedora} >= %{min_fedora}) || (0%{?rhel} && 0%{?rhel} >= %{min_rhel}) %define supported_platform 1 -- 2.21.0
On Wed, Jul 3, 2019 at 6:44 PM Cole Robinson <crobinso@redhat.com> wrote:
Some fedora version tweaks
Cole Robinson (2): spec: Unconditionally build python2 on Fedora spec: Bump minimum supported Fedora version to 29
libvirt-python.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
participants (2)
-
Cole Robinson -
Fabiano Fidêncio