[PATCH] Deprecate the "-no-acpi" command line switch
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays. Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ee95bcb1a6..15084f7bea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -99,6 +99,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead. +``-no-acpi`` (since 8.0) +'''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. + ``-accel hax`` (since 8.0) '''''''''''''''''''''''''' diff --git a/softmmu/vl.c b/softmmu/vl.c index 459588aa7d..07d5215325 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv) vnc_parse(optarg); break; case QEMU_OPTION_no_acpi: + warn_report("-no-hpet is deprecated, use '-machine acpi=off' instead"); qdict_put_str(machine_opts_dict, "acpi", "off"); break; case QEMU_OPTION_no_hpet: -- 2.31.1
On 24/2/23 08:34, Thomas Huth wrote:
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote:
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ee95bcb1a6..15084f7bea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -99,6 +99,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead.
+``-no-acpi`` (since 8.0) +'''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. + ``-accel hax`` (since 8.0) ''''''''''''''''''''''''''
diff --git a/softmmu/vl.c b/softmmu/vl.c index 459588aa7d..07d5215325 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv) vnc_parse(optarg); break; case QEMU_OPTION_no_acpi: + warn_report("-no-hpet is deprecated, use '-machine acpi=off' instead");
"no-acpi" is deprecated? Is my understanding correct that there is no need to update qemu-options.hx ? Thanks, Sunil
On 24/02/2023 08.56, Sunil V L wrote:
On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote:
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ee95bcb1a6..15084f7bea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -99,6 +99,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead.
+``-no-acpi`` (since 8.0) +'''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. + ``-accel hax`` (since 8.0) ''''''''''''''''''''''''''
diff --git a/softmmu/vl.c b/softmmu/vl.c index 459588aa7d..07d5215325 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv) vnc_parse(optarg); break; case QEMU_OPTION_no_acpi: + warn_report("-no-hpet is deprecated, use '-machine acpi=off' instead");
"no-acpi" is deprecated?
That's at least my plan. The patch is under discussion, but at least in my opinion, this option should go away in the long run, yes.
Is my understanding correct that there is no need to update qemu-options.hx ?
If nobody objects to my patch here, it indeed does not make too much sense to enable -no-acpi on risc-v or other platforms now, yes. Thomas
On Fri, Feb 24, 2023 at 08:59:41AM +0100, Thomas Huth wrote:
On 24/02/2023 08.56, Sunil V L wrote:
On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote:
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ee95bcb1a6..15084f7bea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -99,6 +99,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead. +``-no-acpi`` (since 8.0) +'''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. + ``-accel hax`` (since 8.0) '''''''''''''''''''''''''' diff --git a/softmmu/vl.c b/softmmu/vl.c index 459588aa7d..07d5215325 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv) vnc_parse(optarg); break; case QEMU_OPTION_no_acpi: + warn_report("-no-hpet is deprecated, use '-machine acpi=off' instead");
"no-acpi" is deprecated?
That's at least my plan. The patch is under discussion, but at least in my opinion, this option should go away in the long run, yes.
Sorry for not being clear. It is mentioned as -no-hpet is deprecated. It should be -no-acpi. Thanks, Sunil
On 24/02/2023 09.20, Sunil V L wrote:
On Fri, Feb 24, 2023 at 08:59:41AM +0100, Thomas Huth wrote:
On 24/02/2023 08.56, Sunil V L wrote:
On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote:
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ softmmu/vl.c | 1 + 2 files changed, 7 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ee95bcb1a6..15084f7bea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -99,6 +99,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead. +``-no-acpi`` (since 8.0) +'''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. + ``-accel hax`` (since 8.0) '''''''''''''''''''''''''' diff --git a/softmmu/vl.c b/softmmu/vl.c index 459588aa7d..07d5215325 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv) vnc_parse(optarg); break; case QEMU_OPTION_no_acpi: + warn_report("-no-hpet is deprecated, use '-machine acpi=off' instead");
"no-acpi" is deprecated?
That's at least my plan. The patch is under discussion, but at least in my opinion, this option should go away in the long run, yes.
Sorry for not being clear. It is mentioned as -no-hpet is deprecated. It should be -no-acpi.
D'oh, stupid copy-n-paste bug! Thanks, I'll send a v2 :-) Thomas
participants (3)
-
Philippe Mathieu-Daudé -
Sunil V L -
Thomas Huth