12:21 a.m.
*** BLURB HERE ***
Luyao Huang (2):
virsh: fix always return false in domrename
libvirt-domain: forbid use virDomainRename in readonly connection
src/libvirt-domain.c | 1 +
tools/virsh-domain.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
1.8.3.1
12:21 a.m.
New subject: [libvirt] [PATCH 1/2] virsh: fix always return false in domrename
Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 173bb15..437e43e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -9827,7 +9827,7 @@ cmdDomrename(vshControl *ctl, const vshCmd *cmd)
cleanup:
virDomainFree(dom);
- return false;
+ return ret;
}
/*
--
1.8.3.1
12:22 a.m.
New subject: [libvirt] [PATCH 2/2] libvirt-domain: forbid use virDomainRename in readonly connection
This function will change the guest name, we shouldn't
allow the readonly user do this.
Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
---
src/libvirt-domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 9065dab..9314f85 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8796,6 +8796,7 @@ virDomainRename(virDomainPtr dom,
virResetLastError();
virCheckDomainReturn(dom, -1);
virCheckNonNullArgGoto(new_name, error);
+ virCheckReadOnlyGoto(dom->conn->flags, error);
if (dom->conn->driver->domainRename) {
int ret = dom->conn->driver->domainRename(dom, new_name, flags);
--
1.8.3.1
11:53 a.m.
On 08/17/2015 01:21 AM, Luyao Huang wrote:
*** BLURB HERE ***
Luyao Huang (2):
virsh: fix always return false in domrename
libvirt-domain: forbid use virDomainRename in readonly connection
src/libvirt-domain.c | 1 +
tools/virsh-domain.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
ACK and push series,
Good catches,
John
8:46 p.m.
On 08/18/2015 12:53 AM, John Ferlan wrote:
On 08/17/2015 01:21 AM, Luyao Huang wrote:
> *** BLURB HERE ***
>
> Luyao Huang (2):
> virsh: fix always return false in domrename
> libvirt-domain: forbid use virDomainRename in readonly connection
>
> src/libvirt-domain.c | 1 +
> tools/virsh-domain.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
ACK and push series,
Good catches,
Thanks a lot for your quick review.
John
Luyao
3385
days inactive
3386
days old
4 comments
3 participants
participants (3)
-
John Ferlan -
lhuang -
Luyao Huang