[libvirt] [PATCH] xen: Don't add <console> to xml for dom0
It just doesn't really make sense and confuses virt-manager --- src/xenxs/xen_sxpr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 7a53f94..09e7730 100644 --- a/src/xenxs/xen_sxpr.c +++ b/src/xenxs/xen_sxpr.c @@ -1392,7 +1392,7 @@ xenParseSxpr(const struct sexpr *root, chr->target.port = 0; def->parallels[def->nparallels++] = chr; } - } else { + } else if (def->id != 0) { def->nconsoles = 1; if (VIR_ALLOC_N(def->consoles, 1) < 0) goto no_memory; -- 1.7.7.5
On Sun, Jan 29, 2012 at 02:13:10PM -0500, Cole Robinson wrote:
It just doesn't really make sense and confuses virt-manager --- src/xenxs/xen_sxpr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 7a53f94..09e7730 100644 --- a/src/xenxs/xen_sxpr.c +++ b/src/xenxs/xen_sxpr.c @@ -1392,7 +1392,7 @@ xenParseSxpr(const struct sexpr *root, chr->target.port = 0; def->parallels[def->nparallels++] = chr; } - } else { + } else if (def->id != 0) { def->nconsoles = 1; if (VIR_ALLOC_N(def->consoles, 1) < 0) goto no_memory;
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 01/30/2012 06:12 AM, Daniel P. Berrange wrote:
On Sun, Jan 29, 2012 at 02:13:10PM -0500, Cole Robinson wrote:
It just doesn't really make sense and confuses virt-manager --- src/xenxs/xen_sxpr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 7a53f94..09e7730 100644 --- a/src/xenxs/xen_sxpr.c +++ b/src/xenxs/xen_sxpr.c @@ -1392,7 +1392,7 @@ xenParseSxpr(const struct sexpr *root, chr->target.port = 0; def->parallels[def->nparallels++] = chr; } - } else { + } else if (def->id != 0) { def->nconsoles = 1; if (VIR_ALLOC_N(def->consoles, 1) < 0) goto no_memory;
ACK
Daniel
Thanks, pushed now. - Cole
participants (2)
-
Cole Robinson -
Daniel P. Berrange