[Libvir] [PATCH 0/2] Start, shutdown and destroy linux containers
Reposting the patches to start, shutdown and destroy containers with updates for feedback received so far. Thanks! -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization
On Tue, Apr 08, 2008 at 05:02:55PM -0700, Dave Leskovec wrote:
Reposting the patches to start, shutdown and destroy containers with updates for feedback received so far.
This all looks fine to me, Jim founds some parts which might need cleanup, but maybe it would be more easilly adressed with future patches after applying the current set. I'm tempted to apply the two patches and then do the cleanups separately, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Hi Daniel, I went ahead and made some changes based on Jim's comments and posted updated patches. They have the added advantage of having quite a few function header comments added and unnecessary, commented out code deleted. :-) Daniel Veillard wrote:
On Tue, Apr 08, 2008 at 05:02:55PM -0700, Dave Leskovec wrote:
Reposting the patches to start, shutdown and destroy containers with updates for feedback received so far.
This all looks fine to me, Jim founds some parts which might need cleanup, but maybe it would be more easilly adressed with future patches after applying the current set. I'm tempted to apply the two patches and then do the cleanups separately,
Daniel
-- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization
On Thu, Apr 10, 2008 at 12:07:40AM -0700, Dave Leskovec wrote:
Hi Daniel,
I went ahead and made some changes based on Jim's comments and posted updated patches. They have the added advantage of having quite a few function header comments added and unnecessary, commented out code deleted. :-)
Excellent ! I have commited the second set of patches to CVS, I think one of the things i want to do now is switch configure.in default to compile it in so that it gets as much review/check before the next release, thanks a lot ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard -
Dave Leskovec