8:09 a.m.
Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com>
---
src/nwfilter/nwfilter_gentech_driver.c | 4 ++--
src/nwfilter/nwfilter_gentech_driver.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/nwfilter/nwfilter_gentech_driver.c
b/src/nwfilter/nwfilter_gentech_driver.c
index 761a01b..7dd2c97 100644
--- a/src/nwfilter/nwfilter_gentech_driver.c
+++ b/src/nwfilter/nwfilter_gentech_driver.c
@@ -448,7 +448,7 @@ virNWFilterIncludeDefToRuleInst(virNWFilterDriverStatePtr driver,
* the filter and its subfilters.
* @useNewFilter: instruct whether to use a newDef pointer rather than a
* def ptr which is useful during a filter update
- * @foundNewFilter: pointer to int indivating whether a newDef pointer was
+ * @foundNewFilter: pointer to int indicating whether a newDef pointer was
* ever used; variable expected to be initialized to 0 by caller
* @rulesout: array to be filled with rule instance
* @nrulesout: counter to be filled with number of rule instances
@@ -738,7 +738,7 @@ virNWFilterInstantiate(const unsigned char *vmuuid ATTRIBUTE_UNUSED,
if (rc == 0 && (virNetDevValidateConfig(ifname, NULL, ifindex) <= 0))
{
virResetLastError();
- /* interface changed/disppeared */
+ /* interface changed/disappeared */
techdriver->allTeardown(ifname);
rc = -1;
}
diff --git a/src/nwfilter/nwfilter_gentech_driver.h
b/src/nwfilter/nwfilter_gentech_driver.h
index 8349ab4..8163273 100644
--- a/src/nwfilter/nwfilter_gentech_driver.h
+++ b/src/nwfilter/nwfilter_gentech_driver.h
@@ -58,7 +58,7 @@ int virNWFilterInstantiateFilterLate(virNWFilterDriverStatePtr driver,
int virNWFilterTeardownFilter(const virDomainNetDef *net);
virNWFilterHashTablePtr virNWFilterCreateVarHashmap(char *macaddr,
- const virNWFilterVarValue *value);
+ const virNWFilterVarValue *value);
int virNWFilterDomainFWUpdateCB(virDomainObjPtr vm,
void *data);
--
2.1.0
4:27 a.m.
On Fri, Feb 17, 2017 at 07:39:41PM +0530, Nitesh Konkar wrote:
Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com>
---
src/nwfilter/nwfilter_gentech_driver.c | 4 ++--
src/nwfilter/nwfilter_gentech_driver.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
You are sending quite some amount of patches that do no functional
change. That takes review time and adds a lot of unnecesary
communication. While we appreciate patches, sending more and more small
patches that are not really needed is tiresome for most parties
involved.
If we stumple upon such typo or indentation, we either push it right
away as trivial (only if you have push access, though) or just keep it
in a separate branch and after a while, send it as a big patch which is
just one mail. That way it doesn't take that much of a time and
resources.
Most of the time, though, the time spent on the typo/indentation fixing
could be spent on something better, more useful, and also rewarding. So
most of the things get fixed just because someone has some patches
already in that area of code.
Have a nice day,
Martin
9:19 a.m.
On 02/20/2017 05:27 AM, Martin Kletzander wrote:
On Fri, Feb 17, 2017 at 07:39:41PM +0530, Nitesh Konkar wrote:
> Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com>
> ---
> src/nwfilter/nwfilter_gentech_driver.c | 4 ++--
> src/nwfilter/nwfilter_gentech_driver.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
You are sending quite some amount of patches that do no functional
change. That takes review time and adds a lot of unnecesary
communication.
My issue with patches that only change formatting is that any touched
lines will have the history of their last functional change obscured by
the formatting change, making it more difficult to do forensic analysis
of the reasoning behind the code's existence (which is often very useful
when trying to fix a regression without causing a different regression).
These changes can also e the cause of merge errors when backporting
future bug fixes onto older maintenance branches.
Sometimes the advantage of making the change outweighs the potential
extra burden, but not always. Clean consistent code is nice to have, but
it doesn't need to be perfect.
2865
days inactive
2868
days old
2 comments
3 participants
participants (3)
-
Laine Stump -
Martin Kletzander -
Nitesh Konkar