[libvirt] syntax-check Argument list too long problems
Hi, Not so long ago I've started encountering issues with syntax-check, for example: trailing_blank /bin/sh: grep: Argument list too long When I'm running it with SHELL='sh -x' I can see that it's indeed trying to run grep with really long list of files, e.g.: + grep -nE '\<error *\([^"]*"[^"]*[a-z]{3}' .ctags .dir-locals.el ... and many many other files in the list. I see this problem on FreeBSD, but not on Linux, I guess that's because ARG_MAX is much lower on FreeBSD: freebsd$ getconf ARG_MAX 262144 linux$ getconf ARG_MAX 2097152 It looks like it's not possible to change ARG_MAX value on FreeBSD. Do I get it right that it's something that I need to report to gnulib? Roman Bogorodskiy
[adding bug-gnulib] On 08/20/2015 08:30 AM, Roman Bogorodskiy wrote:
Hi,
Not so long ago I've started encountering issues with syntax-check, for example:
trailing_blank /bin/sh: grep: Argument list too long
When I'm running it with SHELL='sh -x' I can see that it's indeed trying to run grep with really long list of files, e.g.:
+ grep -nE '\<error *\([^"]*"[^"]*[a-z]{3}' .ctags .dir-locals.el ...
and many many other files in the list.
I see this problem on FreeBSD, but not on Linux, I guess that's because ARG_MAX is much lower on FreeBSD:
freebsd$ getconf ARG_MAX 262144 linux$ getconf ARG_MAX 2097152
It looks like it's not possible to change ARG_MAX value on FreeBSD. Do I get it right that it's something that I need to report to gnulib?
Reported. I'm not sure what it would take to work xargs into the mix to allow breaking up the list of files to be checked into manageable chunks. But hopefully all of the syntax checks still work in piecewise fashion. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Thu, Aug 20, 2015 at 06:30:12PM +0300, Roman Bogorodskiy wrote:
Hi,
Not so long ago I've started encountering issues with syntax-check, for example:
trailing_blank /bin/sh: grep: Argument list too long
When I'm running it with SHELL='sh -x' I can see that it's indeed trying to run grep with really long list of files, e.g.:
+ grep -nE '\<error *\([^"]*"[^"]*[a-z]{3}' .ctags .dir-locals.el ...
and many many other files in the list.
I see this problem on FreeBSD, but not on Linux, I guess that's because ARG_MAX is much lower on FreeBSD:
freebsd$ getconf ARG_MAX 262144 linux$ getconf ARG_MAX 2097152
It looks like it's not possible to change ARG_MAX value on FreeBSD. Do I get it right that it's something that I need to report to gnulib?
Roman Bogorodskiy
It depends. We have some syntax-check rules that need fixing, but the one you reported seems like it's gnulib's own one. So I'm guessing gnulib should use xargs as well as us for feed the list not to grep only, but anywhere.
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (3)
-
Eric Blake -
Martin Kletzander -
Roman Bogorodskiy