[libvirt] [PATCH] Need to call virFreeError after virSaveLastError
This is a followup to https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html which noted that bridge_driver.c also had a missing virFreeError() call --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 19c9bdb..8da28e4 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2141,6 +2141,7 @@ err: /* return the original error */ virSetError(orig_error); + virFreeError(orig_error); return -1; } -- 1.8.1.4
On 04/30/2013 11:55 AM, John Ferlan wrote:
This is a followup to
https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html
which noted that bridge_driver.c also had a missing virFreeError() call
--- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+)
ACK, okay for 1.0.5.
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 19c9bdb..8da28e4 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2141,6 +2141,7 @@ err:
/* return the original error */ virSetError(orig_error); + virFreeError(orig_error); return -1; }
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 04/30/2013 02:32 PM, Eric Blake wrote:
On 04/30/2013 11:55 AM, John Ferlan wrote:
This is a followup to
https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html
which noted that bridge_driver.c also had a missing virFreeError() call
--- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+)
ACK, okay for 1.0.5.
Thanks.. pushed (as well as the other one) John
participants (2)
-
Eric Blake -
John Ferlan