[libvirt] [PATCH 00/02] libvirt-java add domain flags and error constants up to 0.9, 2
Hi, in order to bring libvirt-java closer to head i will start send a few patches therefore. I start with the domain flags and error constants, as these dont break any older clients, but make it possible to get usefull errorcodes when using it with recent libvirt. Greetings Stefan Majer (2): Added error constants up to libvirt-0.9.12 Added domain flags up to libvirt-0.9.12 src/main/java/org/libvirt/Domain.java | 38 +++++++++++++++++++++++++--- src/main/java/org/libvirt/Error.java | 45 +++++++++++++++++++++++++++++---- 2 files changed, 74 insertions(+), 9 deletions(-) -- 1.7.9.5 -- Stefan Majer
On Tue, Jun 19, 2012 at 11:06:57AM +0200, Stefan Majer wrote:
Hi,
in order to bring libvirt-java closer to head i will start send a few patches therefore. I start with the domain flags and error constants, as these dont break any older clients, but make it possible to get usefull errorcodes when using it with recent libvirt.
Greetings
Stefan Majer (2): Added error constants up to libvirt-0.9.12 Added domain flags up to libvirt-0.9.12
src/main/java/org/libvirt/Domain.java | 38 +++++++++++++++++++++++++--- src/main/java/org/libvirt/Error.java | 45 +++++++++++++++++++++++++++++----
Hi Stefan, both patches looks fine, applied and commited. Could you double check your mail settings, because you are sending patches as application/octet-stream Mime-Type and they can't be read online with the message, making review harder (text/plain would work well if you can change this !) Keep the patches coming :-) thanks a lot ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Hi Daniel, thanks a lot, i will try my very best for the next patch submission. Greetings Stefan On Tue, Jun 26, 2012 at 5:30 AM, Daniel Veillard <veillard@redhat.com> wrote:
On Tue, Jun 19, 2012 at 11:06:57AM +0200, Stefan Majer wrote:
Hi,
in order to bring libvirt-java closer to head i will start send a few patches therefore. I start with the domain flags and error constants, as these dont break any older clients, but make it possible to get usefull errorcodes when using it with recent libvirt.
Greetings
Stefan Majer (2): Added error constants up to libvirt-0.9.12 Added domain flags up to libvirt-0.9.12
src/main/java/org/libvirt/Domain.java | 38 +++++++++++++++++++++++++--- src/main/java/org/libvirt/Error.java | 45 +++++++++++++++++++++++++++++----
Hi Stefan,
both patches looks fine, applied and commited. Could you double check your mail settings, because you are sending patches as application/octet-stream Mime-Type and they can't be read online with the message, making review harder (text/plain would work well if you can change this !) Keep the patches coming :-)
thanks a lot !
Daniel
-- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
-- Stefan Majer
participants (2)
-
Daniel Veillard -
Stefan Majer