[libvirt] [jenkins-ci PATCH v2 1/2] guests: Update test dependencies for osinfo-db
The new dependencies are: - python3 - python3-lxml - python3-pytest - python3-requests xmllint has been removed in favour of a own crafted test using python3-lxml Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/projects/osinfo-db.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guests/vars/projects/osinfo-db.yml b/guests/vars/projects/osinfo-db.yml index d9320a4..56bd77a 100644 --- a/guests/vars/projects/osinfo-db.yml +++ b/guests/vars/projects/osinfo-db.yml @@ -1,4 +1,7 @@ --- packages: - intltool - - xmllint + - python3 + - python3-lxml + - python3-pytest + - python3-requests -- 2.20.1
osinfo-db tests are Python3 only. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/build/projects/osinfo-db.yml | 13 +++++++++++++ jenkins/projects/osinfo-db.yaml | 9 +++++++++ 2 files changed, 22 insertions(+) diff --git a/guests/playbooks/build/projects/osinfo-db.yml b/guests/playbooks/build/projects/osinfo-db.yml index cc88fe8..ca3a1b9 100644 --- a/guests/playbooks/build/projects/osinfo-db.yml +++ b/guests/playbooks/build/projects/osinfo-db.yml @@ -13,6 +13,19 @@ $MAKE install OSINFO_DB_TARGET="--system" - include: '{{ playbook_base }}/jobs/generic-check-job.yml' vars: + # osinfo-db tests are Python 3 only, so they can't be ran on CentOS 7; + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-debian-sid + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 + - libvirt-freebsd-current + - libvirt-ubuntu-16 + - libvirt-ubuntu-18 command: | $MAKE check - include: '{{ playbook_base }}/jobs/generic-rpm-job.yml' diff --git a/jenkins/projects/osinfo-db.yaml b/jenkins/projects/osinfo-db.yaml index 87b6748..87d2a4b 100644 --- a/jenkins/projects/osinfo-db.yaml +++ b/jenkins/projects/osinfo-db.yaml @@ -13,6 +13,15 @@ $MAKE install OSINFO_DB_TARGET="--system" - generic-check-job: parent_jobs: 'osinfo-db-build' + # osinfo-db tests are Python 3 only, so they can't be ran on CentOS 7; + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 command: | $MAKE check - generic-rpm-job: -- 2.20.1
On Tue, Mar 26, 2019 at 05:32:59PM +0100, Fabiano Fidêncio wrote:
osinfo-db tests are Python3 only.
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/build/projects/osinfo-db.yml | 13 +++++++++++++ jenkins/projects/osinfo-db.yaml | 9 +++++++++ 2 files changed, 22 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Tue, Mar 26, 2019 at 05:32:58PM +0100, Fabiano Fidêncio wrote:
The new dependencies are: - python3 - python3-lxml - python3-pytest - python3-requests
xmllint has been removed in favour of a own crafted test using python3-lxml
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/projects/osinfo-db.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Tue, 2019-03-26 at 17:32 +0100, Fabiano Fidêncio wrote:
The new dependencies are: - python3 - python3-lxml - python3-pytest - python3-requests
xmllint has been removed in favour of a own crafted test using python3-lxml
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/projects/osinfo-db.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Series Reviewed-by: Andrea Bolognani <abologna@redhat.com> and pushed after picking up Dan's R-bs. PS: please make sure you include a cover letter next time you send more than a single patch :) -- Andrea Bolognani / Red Hat / Virtualization
participants (3)
-
Andrea Bolognani -
Daniel P. Berrangé -
Fabiano Fidêncio