[libvirt] [libvirt-perl][PATCH 0/2] Catch up with latest libvirt
Two public constants are to be introduced in libvirt. While touching that are of code, update documentation to a constant of the same origin. Michal Privoznik (2): Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants Expand description for PERF_PARAM_CMT constant Changes | 1 + Virt.xs | 2 ++ lib/Sys/Virt/Domain.pm | 16 +++++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) -- 2.8.3
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- Changes | 1 + Virt.xs | 2 ++ lib/Sys/Virt/Domain.pm | 12 ++++++++++++ 3 files changed, 15 insertions(+) diff --git a/Changes b/Changes index 45c49f2..8a94eb1 100644 --- a/Changes +++ b/Changes @@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt 1.3.5 2016-00-00 - Add VIR_ERR_NO_CLIENT constant + - Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants 1.3.4 2016-05-05 diff --git a/Virt.xs b/Virt.xs index d069abd..ef3b508 100644 --- a/Virt.xs +++ b/Virt.xs @@ -7967,6 +7967,8 @@ BOOT: REGISTER_CONSTANT(VIR_DOMAIN_NUMATUNE_MEM_INTERLEAVE, NUMATUNE_MEM_INTERLEAVE); REGISTER_CONSTANT_STR(VIR_PERF_PARAM_CMT, PERF_PARAM_CMT); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_MBML, PERF_PARAM_MBML); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_MBMT, PERF_PARAM_MBMT); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_AVERAGE, BANDWIDTH_IN_AVERAGE); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_PEAK, BANDWIDTH_IN_PEAK); diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index de80162..0a5e89f 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -2642,6 +2642,18 @@ which can be monitored for a guest The CMT event counter +=item Sys::Virt::Domain::PERF_PARAM_MBML + +The MBML event counter which can be used to monitor the amount of +data (bytes/s) sent through the memory controller on the socket. +It corresponds to the "perf.mbml" field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_MBMT + +The MBMT event counter which can be used to monitor total system +bandwidth (bytes/s) from one level of cache to another. It +corresponds to the "perf.mbmt" field in the *Stats APIs. + =back =head2 VCPU FLAGS -- 2.8.3
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- lib/Sys/Virt/Domain.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 0a5e89f..6655b49 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -2640,7 +2640,9 @@ which can be monitored for a guest =item Sys::Virt::Domain::PERF_PARAM_CMT -The CMT event counter +The CMT event counter which can be used to measure the usage of +cache (bytes) by applications running on the platform. It +corresponds to the "perf.cmt" field in the *Stats APIs. =item Sys::Virt::Domain::PERF_PARAM_MBML -- 2.8.3
On Thu, May 26, 2016 at 06:01:03PM +0200, Michal Privoznik wrote:
Two public constants are to be introduced in libvirt. While touching that are of code, update documentation to a constant of the same origin.
Michal Privoznik (2): Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants Expand description for PERF_PARAM_CMT constant
Changes | 1 + Virt.xs | 2 ++ lib/Sys/Virt/Domain.pm | 16 +++++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-)
ACK both Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 31.05.2016 10:56, Daniel P. Berrange wrote:
On Thu, May 26, 2016 at 06:01:03PM +0200, Michal Privoznik wrote:
Two public constants are to be introduced in libvirt. While touching that are of code, update documentation to a constant of the same origin.
Michal Privoznik (2): Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants Expand description for PERF_PARAM_CMT constant
Changes | 1 + Virt.xs | 2 ++ lib/Sys/Virt/Domain.pm | 16 +++++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-)
ACK both
Pushed, thanks. Michal
participants (2)
-
Daniel P. Berrange -
Michal Privoznik