[PATCH] rpm: Enable Xen support on AArch64
Starting with Linux 5.9, Xen Dom0 works on commonly available AArch64 devices, such as the Raspberry Pi 4. Reference: https://xenproject.org/2020/09/29/xen-on-raspberry-pi-4-adventures/ Signed-off-by: Neal Gompa <ngompa13@gmail.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index aa2bc84be9..470782b23e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,8 +97,8 @@ # Finally set the OS / architecture specific special cases -# Xen is available only on i386 x86_64 ia64 -%ifnarch %{ix86} x86_64 ia64 +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif -- 2.26.2
On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote:
+++ b/libvirt.spec.in +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif
The code change is okay, but duplicating the list of architectures in the comment is kinda pointless and results in unnecessary churn; I would reword it as Xen is available only on some architectures Are you okay with that change? If so, I will add my Reviewed-by: Andrea Bolognani <abologna@redhat.com> and push the patch. -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani <abologna@redhat.com> wrote:
On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote:
+++ b/libvirt.spec.in +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif
The code change is okay, but duplicating the list of architectures in the comment is kinda pointless and results in unnecessary churn; I would reword it as
Xen is available only on some architectures
Are you okay with that change? If so, I will add my
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
and push the patch.
I'm fine with that. I debated making that change myself, too. :) -- 真実はいつも一つ！/ Always, there's only one truth!
On Mon, 2020-10-05 at 12:33 -0400, Neal Gompa wrote:
On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani <abologna@redhat.com> wrote:
On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote:
+++ b/libvirt.spec.in +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif
The code change is okay, but duplicating the list of architectures in the comment is kinda pointless and results in unnecessary churn; I would reword it as
Xen is available only on some architectures
Are you okay with that change? If so, I will add my
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
and push the patch.
I'm fine with that. I debated making that change myself, too. :)
Fixed the obvious conflict with commit 5eb6d5401ded7896d6f5b30c10499157a08d6833 Author: Daniel P. Berrangé <berrange@redhat.com> Date: Mon Oct 5 13:17:02 2020 +0100 rpm: drop ia64, sparc64 and alpha architectures None of these arches are relevant to current Fedora or RHEL distros. Reviewed-by: Andrea Bolognani <abologna@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> adjusted the comment as agreed and pushed. -- Andrea Bolognani / Red Hat / Virtualization
On a Sunday in 2020, Neal Gompa wrote:
Starting with Linux 5.9, Xen Dom0 works on commonly available AArch64 devices, such as the Raspberry Pi 4.
My Fedora 32 does not even have 5.9 yet, does it make sense to allow it regardless of the version? Jano
Reference: https://xenproject.org/2020/09/29/xen-on-raspberry-pi-4-adventures/
Signed-off-by: Neal Gompa <ngompa13@gmail.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index aa2bc84be9..470782b23e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,8 +97,8 @@
# Finally set the OS / architecture specific special cases
-# Xen is available only on i386 x86_64 ia64 -%ifnarch %{ix86} x86_64 ia64 +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif
-- 2.26.2
On Mon, Oct 05, 2020 at 12:33:23PM +0200, Ján Tomko wrote:
On a Sunday in 2020, Neal Gompa wrote:
Starting with Linux 5.9, Xen Dom0 works on commonly available AArch64 devices, such as the Raspberry Pi 4.
My Fedora 32 does not even have 5.9 yet, does it make sense to allow it regardless of the version?
New kernels get pushed to all Fedora stable releases, so I'd expect it to appear in F32 in time. The "xen" RPM in Fedora as aarch64 enabled in F32 already, so libxl is available for libvirt to build against.
Jano
Reference: https://xenproject.org/2020/09/29/xen-on-raspberry-pi-4-adventures/
Signed-off-by: Neal Gompa <ngompa13@gmail.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index aa2bc84be9..470782b23e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,8 +97,8 @@
# Finally set the OS / architecture specific special cases
-# Xen is available only on i386 x86_64 ia64 -%ifnarch %{ix86} x86_64 ia64 +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif
-- 2.26.2
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (4)
-
Andrea Bolognani -
Daniel P. Berrangé -
Ján Tomko -
Neal Gompa