On Mon, Jul 23, 2007 at 07:06:25PM +0100, Daniel P. Berrange wrote: > In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a > particular IP address. THis patch adapts the code so that it honours the > 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also > re-enables the tests for this capability that I temporarily disabled. There was a further complication of this. It turns out our handling of headless VMs was broken -ie, VMs without any <graphics> tag all. We specify -nographic on the command line. Unfortunately when you do this, QEMU splatters any settings for monitor, serial or parallel device you gave on the command line before the -nographic flag. Unfortunately again we order -monitor pty before -nographic, so we fail to get a monitor console setup correctly. This updated patch extends the previous so that we have -nographic before all other args it might affect.

+ /* + * NB, -nographic *MUST* come before any serial, or monitor + * or parallel port flags due to QEMU craziness, where it + * decides to change the serial port & monitor to be on stdout + * if you ask for nographic. So we have to make sure we override + * these stupid defaults ourselves + */

On Mon, Jul 23, 2007 at 07:06:25PM +0100, Daniel P. Berrange wrote: > In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a > particular IP address. THis patch adapts the code so that it honours the > 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also > re-enables the tests for this capability that I temporarily disabled. There was a further complication of this. It turns out our handling of headless VMs was broken -ie, VMs without any <graphics> tag all. We specify -nographic on the command line. Unfortunately when you do this, QEMU splatters any settings for monitor, serial or parallel device you gave on the command line before the -nographic flag. Unfortunately again we order -monitor pty before -nographic, so we fail to get a monitor console setup correctly. This updated patch extends the previous so that we have -nographic before all other args it might affect. src/qemu_conf.c | 52 +++++++++++---- src/qemu_conf.h | 1 tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 2 tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.args | 2 tests/qemuxml2argvdata/qemuxml2argv-boot-network.args | 2 tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.args | 2 tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args | 2 tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 2 tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.args | 2 tests/qemuxml2argvdata/qemuxml2argv-disk-many.args | 2 tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args | 2 tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.args | 2 tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.args | 2 tests/qemuxml2argvdata/qemuxml2argv-minimal.args | 2 tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.args | 2 tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.args | 2 tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 2 tests/qemuxml2argvtest.c | 4 - tests/qemuxml2xmltest.c | 2 19 files changed, 59 insertions(+), 30 deletions(-)