[Libvir] Patch: export virConf* symbols
The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)
On Wed, Feb 28, 2007 at 04:29:14PM +0000, Richard W.M. Jones wrote:
The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib.
We can change these to be exported with a leading underscore, and add macros in the private src/conf.h like #define virConfGetValue(c, v) _virConfGetValue(c, v) That lets code in the libvirt tree access the symbols normally, while making it clear to out-of-tree people that these are private symbols. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Daniel P. Berrange wrote:
On Wed, Feb 28, 2007 at 04:29:14PM +0000, Richard W.M. Jones wrote:
The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib.
We can change these to be exported with a leading underscore, and add macros in the private src/conf.h like
#define virConfGetValue(c, v) _virConfGetValue(c, v)
That lets code in the libvirt tree access the symbols normally, while making it clear to out-of-tree people that these are private symbols.
I'll resubmit this patch. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)
participants (2)
-
Daniel P. Berrange -
Richard W.M. Jones