[libvirt] [PATCH] virt-login-shell: mark as Linux only
Currently, virt-login-shell is not allowed to build on Windows. Howerver, as it's designed around LXC, it does not make sense to build it on anything but Linux, so make the check strickter and allow to enable it on Linux only. --- m4/virt-login-shell.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index d5e2e00..55dcaf3 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -21,9 +21,9 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ m4_divert_text([DEFAULTS], [with_login_shell=check]) if test "x$with_login_shell" != "xno"; then - if test "x$with_win" = "xyes"; then + if test "x$with_linux" != "xyes"; then if test "x$with_login_shell" = "xyes"; then - AC_MSG_ERROR([virt-login-shell is not supported on Windows]) + AC_MSG_ERROR([virt-login-shell is supported on Linux only]) else with_login_shell=no; fi -- 2.7.4
Roman Bogorodskiy wrote:
Currently, virt-login-shell is not allowed to build on Windows. Howerver, as it's designed around LXC, it does not make sense to build it on anything but Linux, so make the check strickter and allow to ^^^^^^^^^
stricter*
enable it on Linux only. --- m4/virt-login-shell.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index d5e2e00..55dcaf3 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -21,9 +21,9 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ m4_divert_text([DEFAULTS], [with_login_shell=check])
if test "x$with_login_shell" != "xno"; then - if test "x$with_win" = "xyes"; then + if test "x$with_linux" != "xyes"; then if test "x$with_login_shell" = "xyes"; then - AC_MSG_ERROR([virt-login-shell is not supported on Windows]) + AC_MSG_ERROR([virt-login-shell is supported on Linux only]) else with_login_shell=no; fi
FWIW, the following compilation error led me to disabling this: gmake[3]: Entering directory '/usr/home/novel/code/libvirt/tools' CC virt_login_shell-virt-login-shell.o virt-login-shell.c: In function 'main': virt-login-shell.c:428:9: error: implicit declaration of function 'clearenv' [-Werror=implicit-function-declaration] clearenv(); ^ virt-login-shell.c:428:9: error: nested extern declaration of 'clearenv' [-Werror=nested-externs] cc1: all warnings being treated as errors This is weird, because it looks like clearenv() should be provided by gnulib's setenv module which we use already. Anyway, again, as I don't see how virt-login-shell could be used on non-Linux, I'm not sure it's worth to fix this issue, unless it's not FreeBSD-specific. Roman Bogorodskiy
On Sun, Jun 12, 2016 at 12:11:09PM +0300, Roman Bogorodskiy wrote:
Currently, virt-login-shell is not allowed to build on Windows. Howerver, as it's designed around LXC, it does not make sense to build it on anything but Linux, so make the check strickter and allow to enable it on Linux only. --- m4/virt-login-shell.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index d5e2e00..55dcaf3 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -21,9 +21,9 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ m4_divert_text([DEFAULTS], [with_login_shell=check])
if test "x$with_login_shell" != "xno"; then - if test "x$with_win" = "xyes"; then + if test "x$with_linux" != "xyes"; then if test "x$with_login_shell" = "xyes"; then - AC_MSG_ERROR([virt-login-shell is not supported on Windows]) + AC_MSG_ERROR([virt-login-shell is supported on Linux only]) else with_login_shell=no; fi
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Daniel P. Berrange wrote:
On Sun, Jun 12, 2016 at 12:11:09PM +0300, Roman Bogorodskiy wrote:
Currently, virt-login-shell is not allowed to build on Windows. Howerver, as it's designed around LXC, it does not make sense to build it on anything but Linux, so make the check strickter and allow to enable it on Linux only. --- m4/virt-login-shell.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index d5e2e00..55dcaf3 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -21,9 +21,9 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ m4_divert_text([DEFAULTS], [with_login_shell=check])
if test "x$with_login_shell" != "xno"; then - if test "x$with_win" = "xyes"; then + if test "x$with_linux" != "xyes"; then if test "x$with_login_shell" = "xyes"; then - AC_MSG_ERROR([virt-login-shell is not supported on Windows]) + AC_MSG_ERROR([virt-login-shell is supported on Linux only]) else with_login_shell=no; fi
ACK
Pushed, thanks! Roman Bogorodskiy
participants (2)
-
Daniel P. Berrange -
Roman Bogorodskiy