[libvirt] [jenkins-ci PATCH v2 0/2] guests: Make rpcgen mapping more future-proof
Changes from [v1]: * use the rpcgen name instead of glibc-rpcgen, which is a just temporary hack and will go away. [v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00422.html Andrea Bolognani (2): guests: Fix package name for rpcgen guests: Make rpcgen mapping more future-proof guests/vars/mappings.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.14.3
The glibc-rpcgen package is just a temporary hack, so we should use the rpcgen name from the get-go instead. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index b79757e..a7032e6 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -607,7 +607,7 @@ mappings: rpcgen: deb: libc-dev-bin rpm: glibc-common - FedoraRawhide: glibc-rpcgen + FedoraRawhide: rpcgen FreeBSD: rpmbuild: -- 2.14.3
Since whatever is in Fedora Rawhide will end up in future Fedora releases, it makes sense to use the newer package as default and override it for existing releases (as well as CentOS), so that no tweaking will be needed when Fedora 28 and later are added to the CI setup. Suggested-by: Peter Krempa <pkrempa@redhat.com> Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index a7032e6..9c194d0 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -606,8 +606,10 @@ mappings: rpcgen: deb: libc-dev-bin - rpm: glibc-common - FedoraRawhide: rpcgen + rpm: rpcgen + CentOS: glibc-common + Fedora26: glibc-common + Fedora27: glibc-common FreeBSD: rpmbuild: -- 2.14.3
On Fri, Jan 12, 2018 at 02:50:47PM +0100, Andrea Bolognani wrote:
Changes from [v1]:
* use the rpcgen name instead of glibc-rpcgen, which is a just temporary hack and will go away.
[v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00422.html
Andrea Bolognani (2): guests: Fix package name for rpcgen guests: Make rpcgen mapping more future-proof
guests/vars/mappings.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Seeing latest build failures though, I appears we need to add in libtirpc-devel too, since the RPC library has been removed from glibc, as well as rpcgen. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Andrea Bolognani -
Daniel P. Berrange