[libvirt] [PATCH glib] Fix name of gvir_config_domain_chardev_source_pty_set_path

From: "Daniel P. Berrange" <berrange@redhat.com> The method gvir_config_domain_chardev_source_pty_set_path was accidentally called gvir_config_domain_source_pty_set_path. This naming flaw in turn caused the introspection data to be incorrectly generated, putting a 'source_pty_set_path' method on the GVirConfigDomain object. --- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c | 4 ++-- libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h | 4 ++-- libvirt-gconfig/libvirt-gconfig.sym | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c index 278515c..d24385e 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c @@ -82,8 +82,8 @@ GVirConfigDomainChardevSourcePty *gvir_config_domain_chardev_source_pty_new_from return GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_PTY(object); } -void gvir_config_domain_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, - const char *path) +void gvir_config_domain_chardev_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, + const char *path) { g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_CHARDEV_SOURCE_PTY(pty)); diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h index 4e350e0..96e05bc 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h @@ -62,8 +62,8 @@ GType gvir_config_domain_chardev_source_pty_get_type(void); GVirConfigDomainChardevSourcePty *gvir_config_domain_chardev_source_pty_new(void); GVirConfigDomainChardevSourcePty *gvir_config_domain_chardev_source_pty_new_from_xml(const gchar *xml, GError **error); -void gvir_config_domain_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, - const char *path); +void gvir_config_domain_chardev_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, + const char *path); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index ccddd88..f8c7cdd 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -66,7 +66,7 @@ LIBVIRT_GCONFIG_0.0.8 { gvir_config_domain_chardev_source_pty_get_type; gvir_config_domain_chardev_source_pty_new; gvir_config_domain_chardev_source_pty_new_from_xml; - gvir_config_domain_source_pty_set_path; + gvir_config_domain_chardev_source_pty_set_path; gvir_config_domain_chardev_source_spicevmc_get_type; gvir_config_domain_chardev_source_spicevmc_new; -- 1.8.2.1

On Fri, Jun 28, 2013 at 03:49:21PM +0100, Daniel P. Berrange wrote:
diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index ccddd88..f8c7cdd 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -66,7 +66,7 @@ LIBVIRT_GCONFIG_0.0.8 { gvir_config_domain_chardev_source_pty_get_type; gvir_config_domain_chardev_source_pty_new; gvir_config_domain_chardev_source_pty_new_from_xml; - gvir_config_domain_source_pty_set_path; + gvir_config_domain_chardev_source_pty_set_path;
This is breaking ABI, not sure whether we should be more explicit about the ABI breakage, or if we can silently fix it as we make no ABI stability guarantees for now. Looks good otherwise. Christophe
participants (2)
-
Christophe Fergeau
-
Daniel P. Berrange