Hmmm... I also realized that I never added the example to the top level Makefile.am EXTRA_DIST. I imagine that would need to be resolved to address adding it to the RPM Would you like me to take a look at this, or will this be something you'll resolve as part of the RPM multlib cleanup? Ben -----Original Message----- From: Daniel Veillard [mailto:veillard@redhat.com] Sent: Fri 10/31/2008 6:16 AM To: Ben Guthro Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] Domain Events Python Bindings (Round 2) On Thu, Oct 30, 2008 at 05:03:28PM -0400, Ben Guthro wrote: Okidoc, I think that's good to go, so applied and commited :-) One of the things I need to check/fix is that the examples from examples/domain-events are also added to the RPMs in the docs section, i will check this, there is a bit of nastyness to avoid problem with multilib if not careful. thanks a lot ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

I just took a look over the commit here: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=471b765ae0fc3efd721d6d... It appears that you may have missed adding the new file python/virConnect.py This file is critical to this patch, as it controls proper callback registration, and cleanup coordination with the C code Ben -----Original Message----- From: Daniel Veillard [mailto:veillard@redhat.com] Sent: Fri 10/31/2008 7:22 AM To: Ben Guthro Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] Domain Events Python Bindings (Round 2) On Fri, Oct 31, 2008 at 07:04:09AM -0400, Ben Guthro wrote: I will handle this :-) don't worry ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/