[libvirt PATCH 0/2] docs: Switch to DuckDuckGo for search
Andrea Bolognani (2): docs: Use DuckDuckGo for website/wiki search docs: Mention use of DuckDuckGo docs/css/libvirt.css | 2 +- docs/js/main.js | 16 +++++++++++----- docs/page.xsl | 8 ++++---- 3 files changed, 16 insertions(+), 10 deletions(-) -- 2.43.0
Ideally we'd just perform the search ourselves, but as long as we have to rely on an external provider, at least make it a somewhat privacy-conscious one. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- docs/js/main.js | 16 +++++++++++----- docs/page.xsl | 4 ++-- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/docs/js/main.js b/docs/js/main.js index 57e1faf030..87b817b287 100644 --- a/docs/js/main.js +++ b/docs/js/main.js @@ -40,12 +40,13 @@ function advancedsearch(e) { var form = document.createElement("form"); form.method = "get"; + var q = document.getElementById("searchq"); var newq = document.createElement("input"); newq.type = "hidden"; newq.name = "q"; + newq.value = q.value; form.appendChild(newq); - var q = document.getElementById("searchq"); var whats = document.getElementsByName("what"); var what = "website"; for (var i = 0; i < whats.length; i++) { @@ -56,15 +57,20 @@ function advancedsearch(e) { } if (what == "website" || what == "wiki") { - form.action = "https://google.com/search"; + form.action = "https://duckduckgo.com/"; + + var newsite = document.createElement("input"); + newsite.type = "hidden"; + newsite.name = "sites"; + form.appendChild(newsite); + if (what == "website") { - newq.value = "site:libvirt.org " + q.value; + newsite.value = "libvirt.org"; } else { - newq.value = "site:wiki.libvirt.org " + q.value; + newsite.value = "wiki.libvirt.org"; } } else if (what == "devs" || "users") { form.action = "https://lists.libvirt.org/archives/search"; - newq.value = q.value; var newl = document.createElement("input"); newl.type = "hidden"; diff --git a/docs/page.xsl b/docs/page.xsl index 27607e4d92..8a1a77fa99 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -77,9 +77,9 @@ </ul> </div> <div id="search"> - <form id="simplesearch" action="https://www.google.com/search" enctype="application/x-www-form-urlencoded" method="get"> + <form id="simplesearch" action="https://duckduckgo.com/" enctype="application/x-www-form-urlencoded" method="get"> <div> - <input id="searchsite" name="sitesearch" type="hidden" value="libvirt.org"/> + <input id="searchsite" name="sites" type="hidden" value="libvirt.org"/> <input id="searchq" name="q" type="text" size="12" value=""/> <input name="submit" type="submit" value="Go"/> </div> -- 2.43.0
The fact that we use an external search provider instead of a built-in search functionality might come as a surprise to users, and some of them might not be comfortable with the arrangement. Mention it in the search interface to avoid surprises. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- docs/css/libvirt.css | 2 +- docs/page.xsl | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index 7021d0b599..0dc3280694 100644 --- a/docs/css/libvirt.css +++ b/docs/css/libvirt.css @@ -476,7 +476,7 @@ td.enumvalue { margin-top: 0em; top: 100px; right: 0px; - width: 13em; + width: 15em; text-align: left; color: white; background: rgb(0, 95, 97); diff --git a/docs/page.xsl b/docs/page.xsl index 8a1a77fa99..1021899b3a 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -85,8 +85,8 @@ </div> </form> <div id="advancedsearch"> - <span><input type="radio" name="what" id="whatwebsite" checked="checked" value="website"/><label for="whatwebsite">Website</label></span> - <span><input type="radio" name="what" id="whatwiki" value="wiki"/><label for="whatwiki">Wiki</label></span> + <span><input type="radio" name="what" id="whatwebsite" checked="checked" value="website"/><label for="whatwebsite">Website <i>(via DuckDuckGo)</i></label></span> + <span><input type="radio" name="what" id="whatwiki" value="wiki"/><label for="whatwiki">Wiki <i>(via DuckDuckGo)</i></label></span> <span><input type="radio" name="what" id="whatdevs" value="devs"/><label for="whatdevs">Developers list</label></span> <span><input type="radio" name="what" id="whatusers" value="users"/><label for="whatusers">Users list</label></span> </div> -- 2.43.0
On Mon, Dec 04, 2023 at 12:15:11PM +0100, Andrea Bolognani wrote:
Andrea Bolognani (2): docs: Use DuckDuckGo for website/wiki search docs: Mention use of DuckDuckGo
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
docs/css/libvirt.css | 2 +- docs/js/main.js | 16 +++++++++++----- docs/page.xsl | 8 ++++---- 3 files changed, 16 insertions(+), 10 deletions(-)
-- 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org
participants (2)
-
Andrea Bolognani -
Martin Kletzander