[PATCH 0/2] qapi: fixes to trace event cleanups
Daniel P. Berrangé (2): docs: document 'unavailable' state is no longer output qapi: correctly mark 'ignore-unavailable' deprecated docs/about/deprecated.rst | 8 ++++++++ docs/about/removed-features.rst | 8 ++++++++ qapi/trace.json | 10 ++++++++-- 3 files changed, 24 insertions(+), 2 deletions(-) -- 2.56.1
The concept of unavailable trace events no longer exists so this enum entry was obsolete. Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/about/removed-features.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 225841bd9bb..3a05891db2b 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -802,6 +802,14 @@ The ability to instrument QEMU helper functions with vCPU-aware trace points was removed in 7.0. +``unavailable`` state no longer reported for trace events (removed in 11.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Trace events are now unconditionally built-in to all QEMU builds, +so the concept of an 'unavailable' trace event no longer exists. +The ``TraceEventState`` value ``unavailable`` can thus never +be reported and has been removed from the schema. + Human Monitor Protocol (HMP) commands ------------------------------------- -- 2.56.1
Daniel P. Berrangé <berrange@redhat.com> writes:
The concept of unavailable trace events no longer exists so this enum entry was obsolete.
Suggest Fixes: 38171f59ccbe ("qapi/qom: Make @qapi-type mandatory in output of qom-list etc.")
Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Markus Armbruster <armbru@redhat.com> writes:
Daniel P. Berrangé <berrange@redhat.com> writes:
The concept of unavailable trace events no longer exists so this enum entry was obsolete.
Suggest
Fixes: 38171f59ccbe ("qapi/qom: Make @qapi-type mandatory in output of qom-list etc.")
Pasto! Instead Fixes: f5c576734881 ("trace: stop tracking static disabled state")
Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Follow the proper QAPI syntax for deprecations and mention it in the documentation. Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/about/deprecated.rst | 8 ++++++++ qapi/trace.json | 10 ++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 0891bbc44de..a39feb23f5b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -182,6 +182,14 @@ execution. This special treatment of ``"no"`` is deprecated. Use an empty string instead. In a future version, ``"no"`` will be treated as a plain file name. +``ignore-unavailable`` in ``trace-event-set-state`` (since 11.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Trace events are now unconditionally built-in to all QEMU builds, +so the concept of an 'unavailable' trace event no longer exists. +The ``ignore-unavailable`` parameter in ``trace-event-set-state`` +thus has no effect and should no longer be used. + Human Machine Protocol (HMP) commands ------------------------------------- diff --git a/qapi/trace.json b/qapi/trace.json index 8533e378977..5792a436115 100644 --- a/qapi/trace.json +++ b/qapi/trace.json @@ -67,10 +67,14 @@ # @enable: Whether to enable tracing. # # @ignore-unavailable: Do not match unavailable events with @name. -# Deprecated: since 11.2 # # Since: 2.2 # +# Features: +# +# @deprecated: @ignore-unavailable no longer has any effect +# (since 11.2) +# # .. qmp-example:: # # -> { "execute": "trace-event-set-state", @@ -78,4 +82,6 @@ # <- { "return": {} } ## { 'command': 'trace-event-set-state', - 'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool' } } + 'data': {'name': 'str', 'enable': 'bool', + '*ignore-unavailable': { 'type': 'bool', + 'features': ['deprecated'] } } } -- 2.56.1
Daniel P. Berrangé <berrange@redhat.com> writes:
Follow the proper QAPI syntax for deprecations and mention it in the documentation.
Fixes: f5c576734881 ("trace: stop tracking static disabled state")
Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
On Thu, Nov 12, 2026 at 8:49 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
Follow the proper QAPI syntax for deprecations and mention it in the documentation.
Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--- docs/about/deprecated.rst | 8 ++++++++ qapi/trace.json | 10 ++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 0891bbc44de..a39feb23f5b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -182,6 +182,14 @@ execution. This special treatment of ``"no"`` is deprecated. Use an empty string instead. In a future version, ``"no"`` will be treated as a plain file name.
+``ignore-unavailable`` in ``trace-event-set-state`` (since 11.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Trace events are now unconditionally built-in to all QEMU builds, +so the concept of an 'unavailable' trace event no longer exists. +The ``ignore-unavailable`` parameter in ``trace-event-set-state`` +thus has no effect and should no longer be used. + Human Machine Protocol (HMP) commands -------------------------------------
diff --git a/qapi/trace.json b/qapi/trace.json index 8533e378977..5792a436115 100644 --- a/qapi/trace.json +++ b/qapi/trace.json @@ -67,10 +67,14 @@ # @enable: Whether to enable tracing. # # @ignore-unavailable: Do not match unavailable events with @name. -# Deprecated: since 11.2 # # Since: 2.2 # +# Features: +# +# @deprecated: @ignore-unavailable no longer has any effect +# (since 11.2) +# # .. qmp-example:: # # -> { "execute": "trace-event-set-state", @@ -78,4 +82,6 @@ # <- { "return": {} } ## { 'command': 'trace-event-set-state', - 'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool' } } + 'data': {'name': 'str', 'enable': 'bool', + '*ignore-unavailable': { 'type': 'bool', + 'features': ['deprecated'] } } } -- 2.56.1
On Thu, Nov 12, 2026 at 04:48:55PM +0000, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2): docs: document 'unavailable' state is no longer output qapi: correctly mark 'ignore-unavailable' deprecated
docs/about/deprecated.rst | 8 ++++++++ docs/about/removed-features.rst | 8 ++++++++ qapi/trace.json | 10 ++++++++-- 3 files changed, 24 insertions(+), 2 deletions(-)
-- 2.56.1
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
participants (4)
-
Daniel P. Berrangé -
Marc-André Lureau -
Markus Armbruster -
Stefan Hajnoczi