[libvirt] Entering freeze for libvirt-3.6.0
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issue) Please give it a try, check other systems, and if everything goes well I will make RC2 over the week-end and 3.6.0 may land on Tuesday the 1st ! Thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote:
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issue)
That's because after 5aec02dc3762 dlopen() and friends are required for building, and mingw doesn't provide them. -- Andrea Bolognani / Red Hat / Virtualization
On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote:
On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote:
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issue)
That's because after 5aec02dc3762 dlopen() and friends are required for building, and mingw doesn't provide them.
No that's not correct - dlopen() is only required if building stateful drivers with libvirtd enabled, and that's not needed with mingw. The biuld failure is actually simpler - its just a test case that's not compiling ../../tests/virdrivermoduletest.c: In function 'mymain': ../../tests/virdrivermoduletest.c:55:33: error: unused variable 'data' [-Werror=unused-variable] struct testDriverModuleData data; ^~~~ At top level: ../../tests/virdrivermoduletest.c:39:12: error: 'testDriverModule' defined but not used [-Werror=unused-function] static int testDriverModule(const void *args) ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[2]: *** [Makefile:5331: virdrivermoduletest.o] Error 1 We simply need to conditionalize that test properly Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Thu, Jul 27, 2017 at 17:20:22 +0100, Daniel Berrange wrote:
On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote:
On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote:
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issue)
That's because after 5aec02dc3762 dlopen() and friends are required for building, and mingw doesn't provide them.
No that's not correct - dlopen() is only required if building stateful drivers with libvirtd enabled, and that's not needed with mingw. The biuld failure is actually simpler - its just a test case that's not compiling
../../tests/virdrivermoduletest.c: In function 'mymain': ../../tests/virdrivermoduletest.c:55:33: error: unused variable 'data' [-Werror=unused-variable] struct testDriverModuleData data; ^~~~ At top level: ../../tests/virdrivermoduletest.c:39:12: error: 'testDriverModule' defined but not used [-Werror=unused-function] static int testDriverModule(const void *args) ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[2]: *** [Makefile:5331: virdrivermoduletest.o] Error 1
We simply need to conditionalize that test properly
Oh, right. I was too eager when deleting the conditionally compiled code. I'll post a patch ...
It is out, I have tagged it in git and pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Seems to work for me, Jenkins also complains about libvirt-master-build having failed but that's more than 3 days ago so looks suspicious. Maybe someone need to retrigger a build there If everything goes well I think I will push early Wed my time for the final release, please give it some testing ! Thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
On Mon, Jul 31, 2017 at 10:11:14 +0800, Daniel Veillard wrote:
It is out, I have tagged it in git and pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
Seems to work for me, Jenkins also complains about libvirt-master-build having failed but that's more than 3 days ago so looks suspicious. Maybe someone need to retrigger a build there
I talked to Pavel about this. Looks like the jenkins agent failed (the java exeption log in the console output). After restarting the agent the build seems to go along. I hope that everything passes, since I've pushed the patches that should fix the MinGW build issue I've introduced. The build takes an hour(!) on that box, so it's still in progress.
participants (4)
-
Andrea Bolognani -
Daniel P. Berrange -
Daniel Veillard -
Peter Krempa