4:43 p.m.
This patchset fixes several spelling and punctuation errors in the
documentation.
Where British vs. American conventions differ, I used Google Trends to
determine which form is most commonly used, globally.
Matt Coleman (3):
Fix a typo in compiling.html.in: that -> from
Fix errors in contribute.html.in
Fix a typo in hacking.rst: "contirbute" -> "contribute"
docs/compiling.html.in | 2 +-
docs/contribute.html.in | 6 +++---
docs/hacking.rst | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
--
2.27.0
4:43 p.m.
New subject: [PATCH 1/3] Fix a typo in compiling.html.in: that -> from
The original author intended to write "different than".
"Different" is commonly followed by "from", "than", and
"to".
Globally, "from" is the most common.
---
docs/compiling.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/compiling.html.in b/docs/compiling.html.in
index a4b8602cd1..c898d16313 100644
--- a/docs/compiling.html.in
+++ b/docs/compiling.html.in
@@ -10,7 +10,7 @@
<p>
libvirt uses the standard setup/build/install steps and mandates
- that the build directory is different that the source directory:
+ that the build directory is different from the source directory:
</p>
<pre>
--
2.27.0
4:43 p.m.
New subject: [PATCH 2/3] Fix errors in contribute.html.in
* Add a period to the end of the page's introductory sentence.
* Correct a spelling error: "Evangalism"/"evangalise" ->
"Evangelism"/"evangelize"
---
docs/contribute.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/contribute.html.in b/docs/contribute.html.in
index 87de12269a..d2001053fc 100644
--- a/docs/contribute.html.in
+++ b/docs/contribute.html.in
@@ -6,7 +6,7 @@
<p>
This page provides guidance on how to contribute to the
- libvirt project
+ libvirt project.
</p>
<ul id="toc"></ul>
@@ -74,11 +74,11 @@
who distribute libvirt may wish to propose a person to
be part of the security handling team, to get early access
to information about forthcoming vulnerability fixes.</li>
- <li><strong>Evangalism</strong>. Work done by the project is of
no benefit
+ <li><strong>Evangelism</strong>. Work done by the project is of
no benefit
unless the (potential) user community knows that it
exists. Thus it is critically important to the health
and future growth of the project, that there are a people
- who evangalise the work created by the project. This can
+ who evangelize the work created by the project. This can
take many forms, writing blog posts (about usage of features,
personal user experiences, areas for future work, and more),
syndicating docs and blogs via social media, giving user
--
2.27.0
4:43 p.m.
New subject: [PATCH 3/3] Fix a typo in hacking.rst: "contirbute" -> "contribute"
---
docs/hacking.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/hacking.rst b/docs/hacking.rst
index 3fc5888a71..858dd2dfc1 100644
--- a/docs/hacking.rst
+++ b/docs/hacking.rst
@@ -15,7 +15,7 @@ libvirt-python) `online <https://gitlab.com/libvirt>`__.
Patches to translations are maintained via the `Fedora Weblate
service <https://translate.fedoraproject.org/projects/libvirt/libvirt>`__.
-If you want to contirbute to translations of libvirt, join the appropriate
+If you want to contribute to translations of libvirt, join the appropriate
language team in Weblate. Translation updates to libvirt will be merged
during the feature freeze window.
--
2.27.0
1:41 a.m.
On Tue, Sep 08, 2020 at 04:43:51PM -0400, Matt Coleman wrote:
This patchset fixes several spelling and punctuation errors in the
documentation.
Where British vs. American conventions differ, I used Google Trends to
determine which form is most commonly used, globally.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Unfortunately, I cannot push the patches until you provide your DCO [1], aka
"Signed-off-by", see our guidelines at [2].
[1] https://developercertificate.org/
[2] https://libvirt.org/hacking.html
Regards,
Erik
3:47 p.m.
I knew I’d miss something... Shucks!
Does this work, or should I start a separate [PATCH v2] thread with the DCO added to the
commit messages?
Signed-off-by: Matt Coleman <matt(a)datto.com>
On Sep 9, 2020, at 1:41 AM, Erik Skultety <eskultet(a)redhat.com>
wrote:
On Tue, Sep 08, 2020 at 04:43:51PM -0400, Matt Coleman wrote:
> This patchset fixes several spelling and punctuation errors in the
> documentation.
>
> Where British vs. American conventions differ, I used Google Trends to
> determine which form is most commonly used, globally.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Unfortunately, I cannot push the patches until you provide your DCO [1], aka
"Signed-off-by", see our guidelines at [2].
[1] https://developercertificate.org/
[2] https://libvirt.org/hacking.html
Regards,
Erik
10:08 p.m.
On Wed, Sep 9, 2020 at 3:48 PM Matt Coleman <mcoleman(a)datto.com> wrote:
I knew I’d miss something... Shucks!
Does this work, or should I start a separate [PATCH v2] thread with the DCO added to the
commit messages?
Signed-off-by: Matt Coleman <matt(a)datto.com>
As we typically amend all patches with the various fake tag goop from
these reviews anyway, I'd be inclined to suggest not forcing a resend
with the Signed-off-by notice being sent here already.
Looks good to me otherwise.
Reviewed-by: Neal Gompa <ngompa13(a)gmail.com>
--
真実はいつも一つ！/ Always, there's only one truth!
3:15 a.m.
On Wed, Sep 09, 2020 at 03:47:42PM -0400, Matt Coleman wrote:
I knew I’d miss something... Shucks!
Does this work, or should I start a separate [PATCH v2] thread with the DCO added to the
commit messages?
Signed-off-by: Matt Coleman <matt(a)datto.com>
Pushed. Congratulations on your first libvirt contribution.
Regards,
Erik
3:20 a.m.
On a Tuesday in 2020, Matt Coleman wrote:
This patchset fixes several spelling and punctuation errors in the
documentation.
Where British vs. American conventions differ, I used Google Trends to
determine which form is most commonly used, globally.
Ah, argumentum ad populum. :)
We use a mix of both in libvirt, depending on which person writes it
and what /dev/urandom says.
Jano
Matt Coleman (3):
Fix a typo in compiling.html.in: that -> from
Fix errors in contribute.html.in
Fix a typo in hacking.rst: "contirbute" -> "contribute"
docs/compiling.html.in | 2 +-
docs/contribute.html.in | 6 +++---
docs/hacking.rst | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
--
2.27.0
1785
days inactive
1787
days old
8 comments
4 participants
participants (4)
-
Erik Skultety -
Ján Tomko -
Matt Coleman -
Neal Gompa