[PATCH] rpc: ssh: Allow SSH_ASKPASS_REQUIRE

openssh 8.4p1 released in Sep 2020 added a feature to force use of SSH_ASKPASS https://man.openbsd.org/ssh.1#SSH_ASKPASS_REQUIRE Don't strip it from the environment Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/rpc/virnetsocket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 79bf8e511a..e8fc2d5f7d 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -850,6 +850,7 @@ int virNetSocketNewConnectSSH(const char *nodename, virCommandAddEnvPass(cmd, "KRB5CCNAME"); virCommandAddEnvPass(cmd, "SSH_AUTH_SOCK"); virCommandAddEnvPass(cmd, "SSH_ASKPASS"); + virCommandAddEnvPass(cmd, "SSH_ASKPASS_REQUIRE"); virCommandAddEnvPass(cmd, "OPENSSL_CONF"); virCommandAddEnvPass(cmd, "DISPLAY"); virCommandAddEnvPass(cmd, "XAUTHORITY"); -- 2.46.0

On Tue, Sep 24, 2024 at 10:50:45AM -0400, Cole Robinson wrote:
openssh 8.4p1 released in Sep 2020 added a feature to force use of SSH_ASKPASS
https://man.openbsd.org/ssh.1#SSH_ASKPASS_REQUIRE
Don't strip it from the environment
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/rpc/virnetsocket.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Cole Robinson
-
Daniel P. Berrangé