[libvirt] [PATCH] Fix crash cpu_shares change event crash on domain startup

Introduced by commit 0dce260. qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead of virQEMUDriverPtr. https://bugzilla.redhat.com/show_bug.cgi?id=1147494 --- src/qemu/qemu_cgroup.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 8819943..bd22b7f 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -674,7 +674,8 @@ qemuSetupCpusetCgroup(virDomainObjPtr vm, static int -qemuSetupCpuCgroup(virDomainObjPtr vm) +qemuSetupCpuCgroup(virQEMUDriverPtr driver, + virDomainObjPtr vm) { qemuDomainObjPrivatePtr priv = vm->privateData; virObjectEventPtr event = NULL; @@ -711,7 +712,7 @@ qemuSetupCpuCgroup(virDomainObjPtr vm) } if (event) - qemuDomainEventQueue(vm->privateData, event); + qemuDomainEventQueue(driver, event); } return 0; @@ -845,7 +846,7 @@ qemuSetupCgroup(virQEMUDriverPtr driver, if (qemuSetupMemoryCgroup(vm) < 0) goto cleanup; - if (qemuSetupCpuCgroup(vm) < 0) + if (qemuSetupCpuCgroup(driver, vm) < 0) goto cleanup; if (qemuSetupCpusetCgroup(vm, nodemask, caps) < 0) -- 1.8.5.5

On 09/29/14 13:54, Ján Tomko wrote:
Introduced by commit 0dce260.
qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead of virQEMUDriverPtr.
https://bugzilla.redhat.com/show_bug.cgi?id=1147494 --- src/qemu/qemu_cgroup.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
ACK

On 09/29/2014 01:55 PM, Peter Krempa wrote:
On 09/29/14 13:54, Ján Tomko wrote:
Introduced by commit 0dce260.
qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead of virQEMUDriverPtr.
https://bugzilla.redhat.com/show_bug.cgi?id=1147494 --- src/qemu/qemu_cgroup.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
ACK
Thanks, pushed now. Jan
participants (2)
-
Ján Tomko
-
Peter Krempa