[PATCH 0/3] Random improvements
I've noticed an old branch. I've accumulated these while working on the networkxmlconftest. Michal Prívozník (3): src: Drop NULL check before calling virBufferEscapeString() network: Format <ip/> element using virXMLFormatElement() networkxmlconftest: s/fail/cleanup/ src/conf/domain_conf.c | 17 ++-- src/conf/network_conf.c | 87 ++++++++----------- src/conf/node_device_conf.c | 4 +- src/qemu/qemu_domain.c | 16 ++-- .../nat-network-dns-hosts-modified.xml | 3 +- .../nat-network-dns-more-hosts.xml | 3 +- .../nat-network-dns-srv-record.xml | 12 +-- .../nat-network-dns-srv-records.xml | 12 +-- .../nat-network-dns-txt-modify-ok.xml | 12 +-- .../nat-network-dns-txt-none.xml | 12 +-- .../nat-network-dns-txt-records.xml | 12 +-- .../nat-network-forward-ifaces.xml | 12 +-- .../nat-network-host-updated.xml | 12 +-- .../nat-network-hosts.xml | 12 +-- .../nat-network-no-forward-ifaces.xml | 12 +-- .../nat-network-no-hosts.xml | 3 +- .../nat-network-no-range.xml | 12 +-- .../nat-network-one-host.xml | 12 +-- tests/networkxml2xmlupdateout/nat-network.xml | 12 +-- .../dhcp6-nat-network.expect.xml | 6 +- .../nat-network-dns-forward-plain.expect.xml | 3 +- ...network-dns-forwarder-no-resolv.expect.xml | 3 +- .../nat-network-dns-forwarders.expect.xml | 3 +- .../nat-network-dns-hosts.expect.xml | 3 +- .../nat-network-dns-local-domain.expect.xml | 3 +- ...-network-dns-srv-record-minimal.expect.xml | 12 +-- .../nat-network-dns-srv-record.expect.xml | 12 +-- .../nat-network-dns-srv-records.expect.xml | 12 +-- .../nat-network-dns-txt-record.expect.xml | 12 +-- .../nat-network-explicit-flood.expect.xml | 12 +-- ...nat-network-forward-nat-address.expect.xml | 12 +-- .../nat-network-forward-nat-ipv6.expect.xml | 3 +- ...-network-forward-nat-no-address.expect.xml | 12 +-- .../nat-network-mtu.expect.xml | 12 +-- .../nat-network-name-with-quotes.expect.xml | 12 +-- .../networkxmlconfdata/nat-network.expect.xml | 12 +-- .../open-network.expect.xml | 3 +- .../ptr-domains-auto.expect.xml | 12 +-- .../routed-network-no-dns.expect.xml | 3 +- .../routed-network.expect.xml | 3 +- tests/networkxmlconftest.c | 18 ++-- 41 files changed, 167 insertions(+), 293 deletions(-) -- 2.52.0
From: Michal Privoznik <mprivozn@redhat.com> There's no need to check if any of the three arguments passed to virBufferEscapeString() is NULL as the function does so itself. Well, in a few places we're comparing the last argument against NULL. Drop the comparison then. Generated using the following spatch: @@ expression X, Y, E; @@ - if (E) virBufferEscapeString(X, Y, E); + virBufferEscapeString(X, Y, E); @@ expression X, Y, E; @@ - if (E) { virBufferEscapeString(X, Y, E); - } Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/conf/domain_conf.c | 17 +++++------------ src/conf/network_conf.c | 13 ++++--------- src/conf/node_device_conf.c | 4 +--- src/qemu/qemu_domain.c | 16 ++++++++-------- 4 files changed, 18 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 03a05366e1..b1a73afef2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -24215,11 +24215,8 @@ virDomainDiskDefFormatIotune(virBuffer *buf, virBufferAsprintf(&childBuf, "<size_iops_sec>%llu</size_iops_sec>\n", disk->blkdeviotune.size_iops_sec); } - - if (disk->blkdeviotune.group_name) { - virBufferEscapeString(&childBuf, "<group_name>%s</group_name>\n", - disk->blkdeviotune.group_name); - } + virBufferEscapeString(&childBuf, "<group_name>%s</group_name>\n", + disk->blkdeviotune.group_name); FORMAT_IOTUNE(total_bytes_sec_max_length); FORMAT_IOTUNE(read_bytes_sec_max_length); @@ -27491,9 +27488,7 @@ virDomainGraphicsAuthDefFormatAttr(virBuffer *buf, if (!def->passwd) return; - if (def->username) - virBufferEscapeString(buf, " username='%s'", - def->username); + virBufferEscapeString(buf, " username='%s'", def->username); if (flags & VIR_DOMAIN_DEF_FORMAT_SECURE) virBufferEscapeString(buf, " passwd='%s'", @@ -27623,8 +27618,7 @@ virDomainGraphicsListenDefFormatAddr(virBuffer *buf, VIR_DOMAIN_DEF_FORMAT_MIGRATABLE)) return; - if (glisten->address) - virBufferEscapeString(buf, " listen='%s'", glisten->address); + virBufferEscapeString(buf, " listen='%s'", glisten->address); } static void @@ -27637,8 +27631,7 @@ virDomainGraphicsDefFormatGL(virBuffer *buf, if (gl != VIR_TRISTATE_BOOL_ABSENT) virBufferAsprintf(&attrBuf, " enable='%s'", virTristateBoolTypeToString(gl)); - if (rendernode) - virBufferEscapeString(&attrBuf, " rendernode='%s'", rendernode); + virBufferEscapeString(&attrBuf, " rendernode='%s'", rendernode); virXMLFormatElement(buf, "gl", &attrBuf, NULL); } diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index fe44fd28c3..26887342e4 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -2000,10 +2000,8 @@ virNetworkDNSDefFormat(virBuffer *buf, for (i = 0; i < def->nfwds; i++) { virBufferAddLit(buf, "<forwarder"); - if (def->forwarders[i].domain) { - virBufferEscapeString(buf, " domain='%s'", - def->forwarders[i].domain); - } + virBufferEscapeString(buf, " domain='%s'", + def->forwarders[i].domain); if (VIR_SOCKET_ADDR_VALID(&def->forwarders[i].addr)) { g_autofree char *addr = virSocketAddrFormat(&def->forwarders[i].addr); int port = virSocketAddrGetPort(&def->forwarders[i].addr); @@ -2093,11 +2091,8 @@ virNetworkIPDefFormat(virBuffer *buf, virBufferAddLit(buf, ">\n"); virBufferAdjustIndent(buf, 2); - - if (def->tftproot) { - virBufferEscapeString(buf, "<tftp root='%s'/>\n", - def->tftproot); - } + virBufferEscapeString(buf, "<tftp root='%s'/>\n", + def->tftproot); if ((def->nranges || def->nhosts)) { size_t i; virBufferAddLit(buf, "<dhcp>\n"); diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index ed0d340aa2..09f9e218a4 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -432,9 +432,7 @@ virNodeDeviceCapUSBDevDefFormat(virBuffer *buf, virBufferAsprintf(buf, "<bus>%d</bus>\n", data->usb_dev.bus); virBufferAsprintf(buf, "<device>%d</device>\n", data->usb_dev.device); - if (data->usb_dev.port) - virBufferEscapeString(buf, "<port>%s</port>\n", - data->usb_dev.port); + virBufferEscapeString(buf, "<port>%s</port>\n", data->usb_dev.port); virBufferAsprintf(buf, "<product id='0x%04x'", data->usb_dev.product); if (data->usb_dev.product_name) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ccbfc8bac7..6fdca4be09 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2335,18 +2335,18 @@ qemuDomainDiskPrivateFormat(virDomainDiskDef *disk, if (priv->nodeCopyOnRead || disk->nthrottlefilters > 0) { virBufferAddLit(buf, "<nodenames>\n"); virBufferAdjustIndent(buf, 2); - if (priv->nodeCopyOnRead) - virBufferEscapeString(buf, "<nodename type='copyOnRead' name='%s'/>\n", - priv->nodeCopyOnRead); + virBufferEscapeString(buf, + "<nodename type='copyOnRead' name='%s'/>\n", + priv->nodeCopyOnRead); if (disk->nthrottlefilters > 0) { for (i = 0; i < disk->nthrottlefilters; i++) { - if (disk->throttlefilters[i]->nodename) - virBufferEscapeString(buf, "<nodename type='throttle-filter' name='%s' ", - disk->throttlefilters[i]->nodename); + virBufferEscapeString(buf, + "<nodename type='throttle-filter' name='%s' ", + disk->throttlefilters[i]->nodename); - if (disk->throttlefilters[i]->group_name) - virBufferEscapeString(buf, "group='%s'/>\n", disk->throttlefilters[i]->group_name); + virBufferEscapeString(buf, "group='%s'/>\n", + disk->throttlefilters[i]->group_name); } } virBufferAdjustIndent(buf, -2); -- 2.52.0
From: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/conf/network_conf.c | 76 +++++++++---------- .../nat-network-dns-hosts-modified.xml | 3 +- .../nat-network-dns-more-hosts.xml | 3 +- .../nat-network-dns-srv-record.xml | 12 +-- .../nat-network-dns-srv-records.xml | 12 +-- .../nat-network-dns-txt-modify-ok.xml | 12 +-- .../nat-network-dns-txt-none.xml | 12 +-- .../nat-network-dns-txt-records.xml | 12 +-- .../nat-network-forward-ifaces.xml | 12 +-- .../nat-network-host-updated.xml | 12 +-- .../nat-network-hosts.xml | 12 +-- .../nat-network-no-forward-ifaces.xml | 12 +-- .../nat-network-no-hosts.xml | 3 +- .../nat-network-no-range.xml | 12 +-- .../nat-network-one-host.xml | 12 +-- tests/networkxml2xmlupdateout/nat-network.xml | 12 +-- .../dhcp6-nat-network.expect.xml | 6 +- .../nat-network-dns-forward-plain.expect.xml | 3 +- ...network-dns-forwarder-no-resolv.expect.xml | 3 +- .../nat-network-dns-forwarders.expect.xml | 3 +- .../nat-network-dns-hosts.expect.xml | 3 +- .../nat-network-dns-local-domain.expect.xml | 3 +- ...-network-dns-srv-record-minimal.expect.xml | 12 +-- .../nat-network-dns-srv-record.expect.xml | 12 +-- .../nat-network-dns-srv-records.expect.xml | 12 +-- .../nat-network-dns-txt-record.expect.xml | 12 +-- .../nat-network-explicit-flood.expect.xml | 12 +-- ...nat-network-forward-nat-address.expect.xml | 12 +-- .../nat-network-forward-nat-ipv6.expect.xml | 3 +- ...-network-forward-nat-no-address.expect.xml | 12 +-- .../nat-network-mtu.expect.xml | 12 +-- .../nat-network-name-with-quotes.expect.xml | 12 +-- .../networkxmlconfdata/nat-network.expect.xml | 12 +-- .../open-network.expect.xml | 3 +- .../ptr-domains-auto.expect.xml | 12 +-- .../routed-network-no-dns.expect.xml | 3 +- .../routed-network.expect.xml | 3 +- 37 files changed, 141 insertions(+), 253 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 26887342e4..17ef1c2a08 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -2065,40 +2065,40 @@ static int virNetworkIPDefFormat(virBuffer *buf, const virNetworkIPDef *def) { - virBufferAddLit(buf, "<ip"); + virBuffer ipAttrBuf = VIR_BUFFER_INITIALIZER; + virBuffer ipChildBuf = VIR_BUFFER_INIT_CHILD(buf); if (def->family) - virBufferAsprintf(buf, " family='%s'", def->family); + virBufferAsprintf(&ipAttrBuf, " family='%s'", def->family); if (VIR_SOCKET_ADDR_VALID(&def->address)) { g_autofree char *addr = virSocketAddrFormat(&def->address); if (!addr) return -1; - virBufferAsprintf(buf, " address='%s'", addr); + virBufferAsprintf(&ipAttrBuf, " address='%s'", addr); } if (VIR_SOCKET_ADDR_VALID(&def->netmask)) { g_autofree char *addr = virSocketAddrFormat(&def->netmask); if (!addr) return -1; - virBufferAsprintf(buf, " netmask='%s'", addr); + virBufferAsprintf(&ipAttrBuf, " netmask='%s'", addr); } if (def->prefix > 0) - virBufferAsprintf(buf, " prefix='%u'", def->prefix); + virBufferAsprintf(&ipAttrBuf, " prefix='%u'", def->prefix); if (def->localPTR) { - virBufferAsprintf(buf, " localPtr='%s'", + virBufferAsprintf(&ipAttrBuf, " localPtr='%s'", virTristateBoolTypeToString(def->localPTR)); } - virBufferAddLit(buf, ">\n"); - virBufferAdjustIndent(buf, 2); - virBufferEscapeString(buf, "<tftp root='%s'/>\n", + virBufferEscapeString(&ipChildBuf, "<tftp root='%s'/>\n", def->tftproot); if ((def->nranges || def->nhosts)) { + virBuffer dhcpChildBuf = VIR_BUFFER_INIT_CHILD(&ipChildBuf); size_t i; - virBufferAddLit(buf, "<dhcp>\n"); - virBufferAdjustIndent(buf, 2); for (i = 0; i < def->nranges; i++) { + virBuffer rangeAttrBuf = VIR_BUFFER_INITIALIZER; + virBuffer rangeChildBuf = VIR_BUFFER_INIT_CHILD(&dhcpChildBuf); virSocketAddrRange addr = def->ranges[i].addr; virNetworkDHCPLeaseTimeDef *lease = def->ranges[i].lease; g_autofree char *saddr = NULL; @@ -2110,75 +2110,69 @@ virNetworkIPDefFormat(virBuffer *buf, if (!(eaddr = virSocketAddrFormat(&addr.end))) return -1; - virBufferAsprintf(buf, "<range start='%s' end='%s'", + virBufferAsprintf(&rangeAttrBuf, " start='%s' end='%s'", saddr, eaddr); if (lease) { - virBufferAddLit(buf, ">\n"); - virBufferAdjustIndent(buf, 2); if (!lease->expiry) { - virBufferAddLit(buf, "<lease expiry='0'/>\n"); + virBufferAddLit(&rangeChildBuf, "<lease expiry='0'/>\n"); } else { - virBufferAsprintf(buf, "<lease expiry='%llu' unit='%s'/>\n", + virBufferAsprintf(&rangeChildBuf, "<lease expiry='%llu' unit='%s'/>\n", lease->expiry, virNetworkDHCPLeaseTimeUnitTypeToString(lease->unit)); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "</range>\n"); - } else { - virBufferAddLit(buf, "/>\n"); } + + virXMLFormatElement(&dhcpChildBuf, "range", &rangeAttrBuf, &rangeChildBuf); } for (i = 0; i < def->nhosts; i++) { + virBuffer hostAttrBuf = VIR_BUFFER_INITIALIZER; + virBuffer hostChildBuf = VIR_BUFFER_INIT_CHILD(&dhcpChildBuf); virNetworkDHCPLeaseTimeDef *lease = def->hosts[i].lease; - virBufferAddLit(buf, "<host"); + if (def->hosts[i].mac) - virBufferAsprintf(buf, " mac='%s'", def->hosts[i].mac); + virBufferAsprintf(&hostAttrBuf, " mac='%s'", def->hosts[i].mac); if (def->hosts[i].id) - virBufferAsprintf(buf, " id='%s'", def->hosts[i].id); + virBufferAsprintf(&hostAttrBuf, " id='%s'", def->hosts[i].id); if (def->hosts[i].name) - virBufferAsprintf(buf, " name='%s'", def->hosts[i].name); + virBufferAsprintf(&hostAttrBuf, " name='%s'", def->hosts[i].name); if (VIR_SOCKET_ADDR_VALID(&def->hosts[i].ip)) { g_autofree char *ipaddr = virSocketAddrFormat(&def->hosts[i].ip); if (!ipaddr) return -1; - virBufferAsprintf(buf, " ip='%s'", ipaddr); + virBufferAsprintf(&hostAttrBuf, " ip='%s'", ipaddr); } if (lease) { - virBufferAddLit(buf, ">\n"); - virBufferAdjustIndent(buf, 2); if (!lease->expiry) { - virBufferAddLit(buf, "<lease expiry='0'/>\n"); + virBufferAddLit(&hostChildBuf, "<lease expiry='0'/>\n"); } else { - virBufferAsprintf(buf, "<lease expiry='%llu' unit='%s'/>\n", + virBufferAsprintf(&hostChildBuf, "<lease expiry='%llu' unit='%s'/>\n", lease->expiry, virNetworkDHCPLeaseTimeUnitTypeToString(lease->unit)); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "</host>\n"); - } else { - virBufferAddLit(buf, "/>\n"); } + + virXMLFormatElement(&dhcpChildBuf, "host", &hostAttrBuf, &hostChildBuf); } if (def->bootfile) { - virBufferEscapeString(buf, "<bootp file='%s'", - def->bootfile); + virBuffer bootpAttrBuf = VIR_BUFFER_INITIALIZER; + + virBufferEscapeString(&bootpAttrBuf, " file='%s'", def->bootfile); if (VIR_SOCKET_ADDR_VALID(&def->bootserver)) { g_autofree char *ipaddr = virSocketAddrFormat(&def->bootserver); if (!ipaddr) return -1; - virBufferEscapeString(buf, " server='%s'", ipaddr); + virBufferEscapeString(&bootpAttrBuf, " server='%s'", ipaddr); } - virBufferAddLit(buf, "/>\n"); + virXMLFormatElement(&dhcpChildBuf, "bootp", &bootpAttrBuf, NULL); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "</dhcp>\n"); + + virXMLFormatElement(&ipChildBuf, "dhcp", NULL, &dhcpChildBuf); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "</ip>\n"); + virXMLFormatElement(buf, "ip", &ipAttrBuf, &ipChildBuf); return 0; } diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-hosts-modified.xml b/tests/networkxml2xmlupdateout/nat-network-dns-hosts-modified.xml index 3183671376..1a334e77d2 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-hosts-modified.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-hosts-modified.xml @@ -24,6 +24,5 @@ <hostname>names</hostname> </host> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-more-hosts.xml b/tests/networkxml2xmlupdateout/nat-network-dns-more-hosts.xml index 21e4ebde5f..5fb300061d 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-more-hosts.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-more-hosts.xml @@ -26,6 +26,5 @@ <hostname>names</hostname> </host> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-srv-record.xml b/tests/networkxml2xmlupdateout/nat-network-dns-srv-record.xml index 3dd19e6698..cca69213a1 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-srv-record.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-srv-record.xml @@ -15,12 +15,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-srv-records.xml b/tests/networkxml2xmlupdateout/nat-network-dns-srv-records.xml index 2bdd9321ff..e643323a9d 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-srv-records.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-srv-records.xml @@ -22,12 +22,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-txt-modify-ok.xml b/tests/networkxml2xmlupdateout/nat-network-dns-txt-modify-ok.xml index 4b4dda094a..03861b9d6a 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-txt-modify-ok.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-txt-modify-ok.xml @@ -15,12 +15,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-txt-none.xml b/tests/networkxml2xmlupdateout/nat-network-dns-txt-none.xml index 93bc7db51d..3f1da54ed8 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-txt-none.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-txt-none.xml @@ -12,12 +12,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-dns-txt-records.xml b/tests/networkxml2xmlupdateout/nat-network-dns-txt-records.xml index 63254d2d88..99090d45c9 100644 --- a/tests/networkxml2xmlupdateout/nat-network-dns-txt-records.xml +++ b/tests/networkxml2xmlupdateout/nat-network-dns-txt-records.xml @@ -16,12 +16,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-forward-ifaces.xml b/tests/networkxml2xmlupdateout/nat-network-forward-ifaces.xml index 13d1fdfa6d..7b3001e287 100644 --- a/tests/networkxml2xmlupdateout/nat-network-forward-ifaces.xml +++ b/tests/networkxml2xmlupdateout/nat-network-forward-ifaces.xml @@ -22,12 +22,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-host-updated.xml b/tests/networkxml2xmlupdateout/nat-network-host-updated.xml index 816ab3835d..d325f8a6ab 100644 --- a/tests/networkxml2xmlupdateout/nat-network-host-updated.xml +++ b/tests/networkxml2xmlupdateout/nat-network-host-updated.xml @@ -12,12 +12,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-hosts.xml b/tests/networkxml2xmlupdateout/nat-network-hosts.xml index eb7acd7083..e05ae29151 100644 --- a/tests/networkxml2xmlupdateout/nat-network-hosts.xml +++ b/tests/networkxml2xmlupdateout/nat-network-hosts.xml @@ -13,12 +13,8 @@ <host mac='00:16:3e:77:f0:0d' name='m.example.com' ip='192.168.122.12'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-no-forward-ifaces.xml b/tests/networkxml2xmlupdateout/nat-network-no-forward-ifaces.xml index 79c97a508f..30019b3db3 100644 --- a/tests/networkxml2xmlupdateout/nat-network-no-forward-ifaces.xml +++ b/tests/networkxml2xmlupdateout/nat-network-no-forward-ifaces.xml @@ -19,12 +19,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-no-hosts.xml b/tests/networkxml2xmlupdateout/nat-network-no-hosts.xml index e3c88ff534..d44e940dee 100644 --- a/tests/networkxml2xmlupdateout/nat-network-no-hosts.xml +++ b/tests/networkxml2xmlupdateout/nat-network-no-hosts.xml @@ -19,6 +19,5 @@ <hostname>names</hostname> </host> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-no-range.xml b/tests/networkxml2xmlupdateout/nat-network-no-range.xml index 7128783cbe..66c1e6cca0 100644 --- a/tests/networkxml2xmlupdateout/nat-network-no-range.xml +++ b/tests/networkxml2xmlupdateout/nat-network-no-range.xml @@ -11,12 +11,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network-one-host.xml b/tests/networkxml2xmlupdateout/nat-network-one-host.xml index 62778e4c5f..38ba109a6e 100644 --- a/tests/networkxml2xmlupdateout/nat-network-one-host.xml +++ b/tests/networkxml2xmlupdateout/nat-network-one-host.xml @@ -11,12 +11,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxml2xmlupdateout/nat-network.xml b/tests/networkxml2xmlupdateout/nat-network.xml index 741352ef14..ebcb7477e0 100644 --- a/tests/networkxml2xmlupdateout/nat-network.xml +++ b/tests/networkxml2xmlupdateout/nat-network.xml @@ -20,12 +20,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/dhcp6-nat-network.expect.xml b/tests/networkxmlconfdata/dhcp6-nat-network.expect.xml index 44bb2d1f5d..20b795ec89 100644 --- a/tests/networkxmlconfdata/dhcp6-nat-network.expect.xml +++ b/tests/networkxmlconfdata/dhcp6-nat-network.expect.xml @@ -13,8 +13,7 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> <dhcp> <range start='2001:db8:ac10:fd01::1:10' end='2001:db8:ac10:fd01::1:ff'/> @@ -25,6 +24,5 @@ <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/> </dhcp> </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-forward-plain.expect.xml b/tests/networkxmlconfdata/nat-network-dns-forward-plain.expect.xml index 76e0f926a9..f87c09e0bd 100644 --- a/tests/networkxmlconfdata/nat-network-dns-forward-plain.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-forward-plain.expect.xml @@ -7,6 +7,5 @@ <bridge name='virbr0' stp='on' delay='0'/> <mac address='52:54:00:00:00:00'/> <dns forwardPlainNames='yes'/> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-forwarder-no-resolv.expect.xml b/tests/networkxmlconfdata/nat-network-dns-forwarder-no-resolv.expect.xml index ab2800331c..0ae5154416 100644 --- a/tests/networkxmlconfdata/nat-network-dns-forwarder-no-resolv.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-forwarder-no-resolv.expect.xml @@ -7,6 +7,5 @@ <dns> <forwarder domain='example.com' addr='192.168.1.1'/> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-forwarders.expect.xml b/tests/networkxmlconfdata/nat-network-dns-forwarders.expect.xml index ee8ba7b1dd..dd117fb9b0 100644 --- a/tests/networkxmlconfdata/nat-network-dns-forwarders.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-forwarders.expect.xml @@ -13,6 +13,5 @@ <forwarder domain='example2.com' addr='192.168.2.1' port='1234'/> <forwarder domain='www.example.com'/> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-hosts.expect.xml b/tests/networkxmlconfdata/nat-network-dns-hosts.expect.xml index f8a609f9cb..a231ea6309 100644 --- a/tests/networkxmlconfdata/nat-network-dns-hosts.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-hosts.expect.xml @@ -24,6 +24,5 @@ <hostname>names</hostname> </host> </dns> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-local-domain.expect.xml b/tests/networkxmlconfdata/nat-network-dns-local-domain.expect.xml index 33f4bbfc32..7b05cb09b0 100644 --- a/tests/networkxmlconfdata/nat-network-dns-local-domain.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-local-domain.expect.xml @@ -7,6 +7,5 @@ <bridge name='virbr0' stp='on' delay='0'/> <mac address='52:54:00:00:00:00'/> <domain name='example.com' localOnly='yes'/> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-srv-record-minimal.expect.xml b/tests/networkxmlconfdata/nat-network-dns-srv-record-minimal.expect.xml index 16032c9af2..559d826c16 100644 --- a/tests/networkxmlconfdata/nat-network-dns-srv-record-minimal.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-srv-record-minimal.expect.xml @@ -16,12 +16,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='fc00:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='fc00:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-srv-record.expect.xml b/tests/networkxmlconfdata/nat-network-dns-srv-record.expect.xml index 0f54a72f95..589c715353 100644 --- a/tests/networkxmlconfdata/nat-network-dns-srv-record.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-srv-record.expect.xml @@ -22,12 +22,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-srv-records.expect.xml b/tests/networkxmlconfdata/nat-network-dns-srv-records.expect.xml index 26b802e1eb..a8e064854d 100644 --- a/tests/networkxmlconfdata/nat-network-dns-srv-records.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-srv-records.expect.xml @@ -17,12 +17,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-dns-txt-record.expect.xml b/tests/networkxmlconfdata/nat-network-dns-txt-record.expect.xml index cba7e9d1f8..4d35e36b5e 100644 --- a/tests/networkxmlconfdata/nat-network-dns-txt-record.expect.xml +++ b/tests/networkxmlconfdata/nat-network-dns-txt-record.expect.xml @@ -16,12 +16,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-explicit-flood.expect.xml b/tests/networkxmlconfdata/nat-network-explicit-flood.expect.xml index c039955543..15950c017b 100644 --- a/tests/networkxmlconfdata/nat-network-explicit-flood.expect.xml +++ b/tests/networkxmlconfdata/nat-network-explicit-flood.expect.xml @@ -13,12 +13,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-forward-nat-address.expect.xml b/tests/networkxmlconfdata/nat-network-forward-nat-address.expect.xml index e3276ac338..af1df7dc2d 100644 --- a/tests/networkxmlconfdata/nat-network-forward-nat-address.expect.xml +++ b/tests/networkxmlconfdata/nat-network-forward-nat-address.expect.xml @@ -17,12 +17,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-forward-nat-ipv6.expect.xml b/tests/networkxmlconfdata/nat-network-forward-nat-ipv6.expect.xml index 642929cc8d..e42939318f 100644 --- a/tests/networkxmlconfdata/nat-network-forward-nat-ipv6.expect.xml +++ b/tests/networkxmlconfdata/nat-network-forward-nat-ipv6.expect.xml @@ -6,6 +6,5 @@ </forward> <bridge name='virbr0' stp='on' delay='0'/> <mac address='52:54:00:00:00:00'/> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-forward-nat-no-address.expect.xml b/tests/networkxmlconfdata/nat-network-forward-nat-no-address.expect.xml index 77fc0b5324..c29debdd30 100644 --- a/tests/networkxmlconfdata/nat-network-forward-nat-no-address.expect.xml +++ b/tests/networkxmlconfdata/nat-network-forward-nat-no-address.expect.xml @@ -16,12 +16,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-mtu.expect.xml b/tests/networkxmlconfdata/nat-network-mtu.expect.xml index 97044c70ec..1865cd0ea3 100644 --- a/tests/networkxmlconfdata/nat-network-mtu.expect.xml +++ b/tests/networkxmlconfdata/nat-network-mtu.expect.xml @@ -14,12 +14,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network-name-with-quotes.expect.xml b/tests/networkxmlconfdata/nat-network-name-with-quotes.expect.xml index c0a9cedc7d..c1f5fee466 100644 --- a/tests/networkxmlconfdata/nat-network-name-with-quotes.expect.xml +++ b/tests/networkxmlconfdata/nat-network-name-with-quotes.expect.xml @@ -16,12 +16,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='fc00:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='fc00:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='fc00:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='fc00:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/nat-network.expect.xml b/tests/networkxmlconfdata/nat-network.expect.xml index 9d3757f0e0..da274e0682 100644 --- a/tests/networkxmlconfdata/nat-network.expect.xml +++ b/tests/networkxmlconfdata/nat-network.expect.xml @@ -13,12 +13,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/open-network.expect.xml b/tests/networkxmlconfdata/open-network.expect.xml index 29e968442b..a4842f6688 100644 --- a/tests/networkxmlconfdata/open-network.expect.xml +++ b/tests/networkxmlconfdata/open-network.expect.xml @@ -4,6 +4,5 @@ <forward mode='open'/> <bridge name='virbr1' stp='on' delay='0'/> <mac address='12:34:56:78:9a:bc'/> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/ptr-domains-auto.expect.xml b/tests/networkxmlconfdata/ptr-domains-auto.expect.xml index fe2047b708..3653852adb 100644 --- a/tests/networkxmlconfdata/ptr-domains-auto.expect.xml +++ b/tests/networkxmlconfdata/ptr-domains-auto.expect.xml @@ -13,12 +13,8 @@ <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/> </dhcp> </ip> - <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0' localPtr='no'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64' localPtr='yes'> - </ip> - <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'> - </ip> - <ip family='ipv4' address='10.24.10.1'> - </ip> + <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0' localPtr='no'/> + <ip family='ipv6' address='2001:db8:ac10:fe01::1' prefix='64' localPtr='yes'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'/> + <ip family='ipv4' address='10.24.10.1'/> </network> diff --git a/tests/networkxmlconfdata/routed-network-no-dns.expect.xml b/tests/networkxmlconfdata/routed-network-no-dns.expect.xml index f68ce8a941..eeec0563ae 100644 --- a/tests/networkxmlconfdata/routed-network-no-dns.expect.xml +++ b/tests/networkxmlconfdata/routed-network-no-dns.expect.xml @@ -7,6 +7,5 @@ <bridge name='virbr1' stp='on' delay='0'/> <mac address='12:34:56:78:9a:bc'/> <dns enable='no'/> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> diff --git a/tests/networkxmlconfdata/routed-network.expect.xml b/tests/networkxmlconfdata/routed-network.expect.xml index 2e13cf4ffa..92e94ac83f 100644 --- a/tests/networkxmlconfdata/routed-network.expect.xml +++ b/tests/networkxmlconfdata/routed-network.expect.xml @@ -6,6 +6,5 @@ </forward> <bridge name='virbr1' zone='myzone' stp='on' delay='0'/> <mac address='12:34:56:78:9a:bc'/> - <ip address='192.168.122.1' netmask='255.255.255.0'> - </ip> + <ip address='192.168.122.1' netmask='255.255.255.0'/> </network> -- 2.52.0
From: Michal Privoznik <mprivozn@redhat.com> Inside of testCompareXMLtoXMLFiles() the 'fail' label is used in both successful and error runs. If that's the case, our coding standard mandates the label to be named 'cleanup'. Change it. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/networkxmlconftest.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/networkxmlconftest.c b/tests/networkxmlconftest.c index b74d5b14f5..7f98004c75 100644 --- a/tests/networkxmlconftest.c +++ b/tests/networkxmlconftest.c @@ -125,16 +125,16 @@ testCompareXMLToConfFiles(const void *data) bool compareFailed = false; if (!(obj = virNetworkObjNew())) - goto fail; + goto cleanup; if (!(def = g_steal_pointer(&info->def))) { /* Previous test wasn't executed. */ if (!(def = virNetworkDefParse(NULL, info->inxml, info->xmlopt, false))) - goto fail; + goto cleanup; if (networkValidateTests(def) < 0) { virNetworkDefFree(def); - goto fail; + goto cleanup; } } @@ -142,17 +142,17 @@ testCompareXMLToConfFiles(const void *data) if (!networkNeedsDnsmasq(def)) { ret = EXIT_AM_SKIP; - goto fail; + goto cleanup; } dctx = dnsmasqContextNew(def->name, "/var/lib/libvirt/dnsmasq"); if (dctx == NULL) - goto fail; + goto cleanup; if (networkDnsmasqConfContents(obj, pidfile, &confactual, &hostsfileactual, dctx, info->caps) < 0) - goto fail; + goto cleanup; /* Any changes to this function ^^ should be reflected here too. */ #ifndef __linux__ @@ -162,7 +162,7 @@ testCompareXMLToConfFiles(const void *data) if (!(tmp = virStringReplace(confactual, "except-interface=lo0\n", "except-interface=lo\n"))) - goto fail; + goto cleanup; VIR_FREE(confactual); confactual = g_steal_pointer(&tmp); } @@ -184,11 +184,11 @@ testCompareXMLToConfFiles(const void *data) } if (compareFailed) - goto fail; + goto cleanup; ret = 0; - fail: + cleanup: VIR_FREE(confactual); virNetworkObjEndAPI(&obj); return ret; -- 2.52.0
On Tue, Mar 17, 2026 at 05:10:02PM +0100, Michal Privoznik via Devel wrote:
I've noticed an old branch. I've accumulated these while working on the networkxmlconftest.
Michal Prívozník (3): src: Drop NULL check before calling virBufferEscapeString() network: Format <ip/> element using virXMLFormatElement() networkxmlconftest: s/fail/cleanup/
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
participants (2)
-
Michal Privoznik -
Pavel Hrdina